Repository navigation
Commit f883b2f
committed
fix(instance-preferences): reject preference lists on recipe trainers with a clear error
Recipe-based trainers (SFTTrainer, DPOTrainer, RLVRTrainer) accept a
Compute for serverful training, and Compute now carries
instance_preferences. Recipes are rendered for one instance type: the
device class selects the image and launcher, and the type is validated
against the model's allowed-type list. A service-chosen type cannot apply,
so instance_preferences is unsupported on this path, as documented.
Today the unsupported case surfaces indirectly. With no instance_type
set, the allowed-type check reports "Instance type 'None' is not
supported" before ModelTrainer.from_recipe can raise its explicit
message. _train_serverful_smtj now rejects a preference list up front,
before the recipe fetch, with the same wording from_recipe uses.
Two existing tests modelled Compute as a bare MagicMock, whose
auto-created instance_preferences attribute is truthy; they now pin it to
None, as a real Compute without preferences reports.1 parent 62dca3b commit f883b2f
4 files changed
Lines changed: 47 additions & 0 deletions
File tree
- sagemaker-train
- src/sagemaker/train
- tests/unit/train
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
901 | 901 | | |
902 | 902 | | |
903 | 903 | | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
904 | 913 | | |
905 | 914 | | |
906 | 915 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
115 | 116 | | |
116 | 117 | | |
117 | 118 | | |
| |||
131 | 132 | | |
132 | 133 | | |
133 | 134 | | |
| 135 | + | |
134 | 136 | | |
135 | 137 | | |
136 | 138 | | |
| |||
147 | 149 | | |
148 | 150 | | |
149 | 151 | | |
| 152 | + | |
150 | 153 | | |
151 | 154 | | |
152 | 155 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
388 | 389 | | |
389 | 390 | | |
390 | 391 | | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| |||
0 commit comments