You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit fe4b745
Browse filesBrowse the repository at this point in the historyBrowse files
fix(serve): support aliased hub content names in private hub deploys (#6039)
* fix(serve): support aliased hub content names in private hub deploys
CreateHubContentReference accepts a custom HubContentName, but the SDK
always looks up hub content by model_id, so a reference named
differently from the public model id fails with ResourceNotFound.
Add optional hub_content_name to JumpStartConfig and thread it through
from_jumpstart_config; when set, _build_for_jumpstart resolves hub
content by the reference's actual name.
Verified E2E against a live private hub with an execution role that has
zero S3 permissions: an aliased ModelReference now deploys successfully
with SageMaker brokering artifact access through the hub content
reference.
* test(serve): private hub regression coverage for HubAccessConfig and aliased names
Unit tests (extends the #5985 file, shared setup hoisted to a
module-level _build_jumpstart_builder helper per package convention):
- model_reference_arn propagation regression test guarding the #6036
fix (supersedes the subset assertions added there)
- CreateModel payload chain test: drives the real unmocked path
_build_for_jumpstart -> _prepare_container_def_base and asserts the
container definition carries S3DataSource.HubAccessConfig.HubContentArn
for hub builds and omits it for public builds -- the assertion that
would have caught the v3.15.1-v3.16.0 regression
- hub_content_name lookup and config threading tests
Integration tests (slow_test, self-provisioning with full teardown):
- test_deploy_with_no_s3_execution_role: zero-S3 execution role deploy,
asserts HubAccessConfig on the created Model (service-side contract)
- test_deploy_with_aliased_hub_content_name: aliased reference deploy
Verified red->green at every layer: 4 unit tests and both integ tests
fail on v3.16.0 baseline; all pass with the fixes (integ verified live
in us-east-1 with a real hub, zero-S3 role, 2 passed in 38s).
---------
Co-authored-by: Eli Davidson <elleedee@amazon.com>
0 commit comments