You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit febee60
Browse filesBrowse the repository at this point in the historyBrowse files
* fix: enforce LF newlines for sm_train.sh on Windows (Fixes#5897)
* test(train): cover LF line endings for sm_train.sh
Adds the unit test from #5907 plus an OS-independent regression guard.
The byte-level check from #5907 (no CRLF in the written sm_train.sh) only
fails on Windows, since POSIX text-mode open() never translates \n. CI runs
on Linux, so that test passes with or without the fix. The second test
inspects the open() call for sm_train.sh and asserts newline="\n", mirroring
the approach merged in #6313 for the mlops repack launcher, so the guard
holds on any host OS.
---------
Co-authored-by: Mohamed Zeidan <81834882+mohamedzeidan2021@users.noreply.github.com>
Co-authored-by: Mohamed Zeidan <zeidmo@amazon.com>
0 commit comments