Skip to content

feature: add support for describe_endpoint_config to session - #5193

Merged
mohamedzeidan2021 merged 3 commits into
aws:master-v2from
nzewail:master
Oct 6, 2026
Merged

mohamedzeidan2021 merged 3 commits into
aws:master-v2from
nzewail:master

Conversation

@nzewail

@nzewail nzewail commented Jun 3, 2025

Copy link
Copy Markdown

Description of changes:

  • Add support for describe_endpoint_config endpoint in Session

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nzewail
nzewail requested a review from a team as a code owner June 3, 2025 20:26
@nzewail
nzewail requested a review from rsareddy0329 June 3, 2025 20:26
@zhaoqizqwang

Copy link
Copy Markdown
Collaborator

Hi, as part of incoming PySDK V3 release, master branch will be replaced by PySDK V3 code. We have changed the target branch to master-v2

@zhaoqizqwang
zhaoqizqwang changed the base branch from master to master-v2 November 19, 2025 21:45
@nzewail

nzewail commented Nov 20, 2025

Copy link
Copy Markdown
Author

Hi, as part of incoming PySDK V3 release, master branch will be replaced by PySDK V3 code. We have changed the target branch to master-v2

Is there anything else I need to do to get this merged in?

@mohamedzeidan2021

Copy link
Copy Markdown
Collaborator

would you still like to get this merged ?

@nzewail

nzewail commented Oct 1, 2026

Copy link
Copy Markdown
Author

would you still like to get this merged ?

Yeah!

@mohamedzeidan2021
mohamedzeidan2021 deployed to manual-approval October 5, 2026 18:13 — with GitHub Actions Active
Fixes the flake8 and black failures reported by the codestyle-doc-tests
check on PR aws#5193:

- Remove trailing whitespace on the blank line preceding the new method
  (flake8 W293 at session.py:5370).
- Wrap the describe_endpoint_config call so the line fits within the
  100-character limit enforced by black 24.3.0.
@mohamedzeidan2021

Copy link
Copy Markdown
Collaborator

The integ-tests check is red because the GitHub runner was killed mid-install, not because anything failed — no tests ran. I re-ran the same CodeBuild project against this PR directly:

Build #2797 (full v2 integ suite, 1h30m, commit ffec306):

= 534 passed, 162 skipped, 2 xfailed, 2 errors, 18 rerun in 5422.76s (1:30:22) =

ERROR tests/integ/sagemaker/lineage/test_context.py::test_action - botocore.e...
ERROR tests/integ/test_predict_stream.py::test_predict_stream - sagemaker.exc...

Zero FAILED. Both errors are pre-existing setup failures that reproduce on unrelated master-v2 PRs (run 37065695222) — a botocore error and a falcon-7b LMI endpoint creation failure. Neither touches this code.

Safe to merge: the change is purely additive

@mohamedzeidan2021
mohamedzeidan2021 merged commit 4afbb5a into aws:master-v2 Oct 6, 2026
2 checks passed
@mohamedzeidan2021

Copy link
Copy Markdown
Collaborator

Merged, thank you so much for contributing!

This branch had an error being deployed

1 failed deployment
manual-approval — 45d1d943 Deployed Oct 6, 2026 by mohamedzeidan2021 via wait-for-approval #247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants