Repository navigation
feature: add support for describe_endpoint_config to session - #5193
Conversation
|
Hi, as part of incoming PySDK V3 release, master branch will be replaced by PySDK V3 code. We have changed the target branch to master-v2 |
Is there anything else I need to do to get this merged in? |
|
would you still like to get this merged ? |
Yeah! |
Fixes the flake8 and black failures reported by the codestyle-doc-tests check on PR aws#5193: - Remove trailing whitespace on the blank line preceding the new method (flake8 W293 at session.py:5370). - Wrap the describe_endpoint_config call so the line fits within the 100-character limit enforced by black 24.3.0.
|
The integ-tests check is red because the GitHub runner was killed mid-install, not because anything failed — no tests ran. I re-ran the same CodeBuild project against this PR directly: Build #2797 (full v2 integ suite, 1h30m, commit ffec306): = 534 passed, 162 skipped, 2 xfailed, 2 errors, 18 rerun in 5422.76s (1:30:22) = ERROR tests/integ/sagemaker/lineage/test_context.py::test_action - botocore.e... Zero FAILED. Both errors are pre-existing setup failures that reproduce on unrelated master-v2 PRs (run 37065695222) — a botocore error and a falcon-7b LMI endpoint creation failure. Neither touches this code. Safe to merge: the change is purely additive |
|
Merged, thank you so much for contributing! |
Description of changes:
describe_endpoint_configendpoint in SessionTesting done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.