Repository navigation
Conversation
…ourceCode object and `get_code_hash` fails to provide a List to the `get_training_code_hash` function
CongaJAMM
had a problem deploying
to
manual-approval
January 30, 2026 20:04 — with 
GitHub Actions
Failure
GitHub Actions
Failure
hillygoose
approved these changes
Feb 12, 2026
Contributor
|
Please add at least a unit test covering SourceCode(requirements=None) in a TrainingStep pipeline is needed to prevent regression. |
| if source_code: | ||
| source_dir = source_code.source_dir | ||
| requirements = source_code.requirements | ||
| requirements = [source_code.requirements] if source_code.requirements else [] |
Contributor
There was a problem hiding this comment.
Change to
requirements = source_code.requirements or None
Collaborator
|
Would you still like to merge this ? If so- please make the change asked for above. |
Collaborator
|
Thanks for contributing! I investigated a bit further and it seems like #5618 makes the changes that your PR attempts to fix. Closing for now, but please reopen or comment if there are any concerns. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed SourceCode.requirements is an optional argument and causes an error when left to default
Nonevalue in a TrainingStep as part of a Pipeline.Catches case where no
requirementsargument is sent to create SourceCode object andget_code_hashfails to provide aListto theget_training_code_hashfunction.Issue #, if available:
Description of changes:
From the
get_code_hashfunction created a conditional statement to get the right DataType to pass toget_training_code_hashand supply a default value.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.