Repository navigation
fix: improve error messages for waiter timeouts - #5785
Merged
Merged
Conversation
joshuatowner
had a problem deploying
to
manual-approval
April 22, 2026 07:17 — with
GitHub Actions
Error
joshuatowner
had a problem deploying
to
manual-approval
April 22, 2026 07:17 — with
GitHub Actions
Error
joshuatowner
had a problem deploying
to
manual-approval
April 22, 2026 07:23 — with
GitHub Actions
Error
joshuatowner
had a problem deploying
to
manual-approval
April 22, 2026 07:23 — with
GitHub Actions
Error
joshuatowner
marked this pull request as ready for review
April 22, 2026 07:35
| raise TimeoutExceededError(resouce_type="TrainingJob", status=current_status) | ||
| raise TimeoutExceededError( | ||
| resource_type="TrainingJob", | ||
| status=current_status, |
Contributor
There was a problem hiding this comment.
You have helped caught typo of this autogenerated script: should be resource_type instead of resouce_type, thanks! Can you help update the source for this script
- https://github.com/aws/sagemaker-python-sdk/blob/master/sagemaker-core/src/sagemaker/core/tools/templates.py#L335, also line 388, 439.
- Regenerate
resources.py:
cd sagemaker-core
python -m sagemaker.core.tools.codegen
- That single template fix will correct all 85+ resources in the generated
resources.py at once
joshuatowner
had a problem deploying
to
manual-approval
April 22, 2026 19:37 — with
GitHub Actions
Error
joshuatowner
had a problem deploying
to
manual-approval
April 22, 2026 19:37 — with
GitHub Actions
Error
mollyheamazon
had a problem deploying
to
manual-approval
April 22, 2026 23:18 — with
GitHub Actions
Error
mollyheamazon
had a problem deploying
to
manual-approval
April 22, 2026 23:18 — with
GitHub Actions
Error
mollyheamazon
temporarily deployed
to
manual-approval
April 22, 2026 23:24 — with
GitHub Actions
Inactive
mollyheamazon
temporarily deployed
to
manual-approval
April 22, 2026 23:24 — with
GitHub Actions
Inactive
mollyheamazon
approved these changes
Apr 23, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve timeout error messages for TrainingJob and EvaluationJob waits
When wait() times out, the current error says "Increase the timeout and try again" — which implies the job stopped and needs to be re-created. In reality, the job is still running server-side; only the client-side polling stopped.
Changes: