Repository navigation
feat: expose poll interval parameter on all trainers - #5859
Merged
Merged
Conversation
joshuatowner
had a problem deploying
to
manual-approval
May 14, 2026 21:09 — with
GitHub Actions
Error
joshuatowner
had a problem deploying
to
manual-approval
May 14, 2026 21:09 — with
GitHub Actions
Error
joshuatowner
force-pushed
the
poll-interval
branch
from
May 15, 2026 06:53
558aca8 to
873b556
Compare
joshuatowner
had a problem deploying
to
manual-approval
May 15, 2026 06:53 — with
GitHub Actions
Error
joshuatowner
had a problem deploying
to
manual-approval
May 15, 2026 06:53 — with
GitHub Actions
Error
joshuatowner
marked this pull request as ready for review
May 18, 2026 07:41
joshuatowner
had a problem deploying
to
manual-approval
May 18, 2026 07:41 — with
GitHub Actions
Error
joshuatowner
had a problem deploying
to
manual-approval
May 18, 2026 07:41 — with
GitHub Actions
Error
joshuatowner
temporarily deployed
to
manual-approval
May 18, 2026 23:47 — with
GitHub Actions
Inactive
joshuatowner
temporarily deployed
to
manual-approval
May 18, 2026 23:47 — with
GitHub Actions
Inactive
jam-jee
approved these changes
May 19, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose poll interval parameter on all trainers
Adds a
pollparameter totrain()on SFTTrainer, DPOTrainer, RLVRTrainer, and RLAIFTrainer, allowing callers to control how frequently the SDK polls for training job status updates.Problem
The
trainer_wait.wait()function already accepts apollparameter (default 5s), but there was no way to configure it from the trainer API. Users running in agent/script contexts want longer intervals (e.g., 30s) to reduce output noise and API calls.Changes
poll: int = 5parameter totrain()on all 4 trainerstrainer_wait.wait()viawait_kwargsTesting
poll=5)