Skip to content

fix: ModelBuilder.build() fails when image_uri is a ParameterString (V2 -> V3 migrati (5760) - #5910

Closed
sagemaker-bot wants to merge 1 commit into
masterfrom
fix/modelbuilder-build-fails-when-image-uri-is-a-5760-2
Closed

sagemaker-bot wants to merge 1 commit into
masterfrom
fix/modelbuilder-build-fails-when-image-uri-is-a-5760-2

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Description

AI-generated fix.

Related Issue

Related issue: 5760

Changes Made

  • sagemaker-serve/src/sagemaker/serve/validations/check_image_uri.py
  • sagemaker-serve/src/sagemaker/serve/validations/check_image_and_hardware_type.py
  • sagemaker-serve/tests/unit/validations/test_check_image_uri.py

AI-Generated PR

This PR was automatically generated by the PySDK Issue Agent.

  • Confidence score: 95%
  • Classification: bug
  • SDK version target: V3

Merge Checklist

  • Changes are backward compatible
  • Commit message follows prefix: description format
  • Unit tests added/updated
  • Integration tests added (if applicable)
  • Documentation updated (if applicable)

@codecov

codecov Bot commented Jun 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.76%. Comparing base (e6905ed) to head (a684d35).
⚠️ Report is 201 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5910      +/-   ##
==========================================
+ Coverage   89.97%   93.76%   +3.79%     
==========================================
  Files         286      188      -98     
  Lines       39217    24012   -15205     
==========================================
- Hits        35286    22516   -12770     
+ Misses       3931     1496    -2435     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@admivsn

admivsn commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Would really appreciate this to be merged to fix #5760

This branch was previously deployed

1 inactive deployment
auto-approve — a684d351 Deployed Jun 1, 2026 by sagemaker-bot via wait-for-approval #617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants