Repository navigation
fix: harden S3 download path handling - #5984
Merged
Merged
Conversation
lucasjia-aws
force-pushed
the
fix/s3-path-traversal-v2
branch
from
July 7, 2026 19:48
ea6588e to
56f93fb
Compare
lucasjia-aws
force-pushed
the
fix/s3-path-traversal-v2
branch
from
July 7, 2026 21:49
56f93fb to
0e4ecc7
Compare
Align master-v2 with master by validating that files downloaded from S3 resolve within the intended destination directory before writing. Adds a shared validate_path_within_directory() helper in sagemaker.utils and wires it into the S3 download paths in _download_files_under_prefix, Session.download_data, mlflow.utils._download_s3_artifacts, and the local transform job. Includes unit tests for the new validation behavior.
lucasjia-aws
force-pushed
the
fix/s3-path-traversal-v2
branch
from
July 8, 2026 02:58
0e4ecc7 to
c8cf415
Compare
Collaborator
Author
|
Strict backport #5804 (fix for v3) to v2 |
lucasjia-aws
changed the title
aviruthen
approved these changes
Jul 8, 2026
papriwal
approved these changes
Jul 8, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align master-v2 with master by validating that files downloaded from S3 resolve within the intended destination directory before writing. Adds a shared validate_path_within_directory() helper in sagemaker.utils and wires it into the S3 download paths in _download_files_under_prefix, Session.download_data, mlflow.utils._download_s3_artifacts, and the local transform job.
Includes unit tests for the new validation behavior.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.