Skip to content

Daily Sync with Botocore v1.43.101 on 2026/09/24 - #6309

Closed
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-24-10-06-46
Closed

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-24-10-06-46

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 26s —— View job


PR Review — Daily Botocore Sync (v1.43.101)

  • Read the PR diff
  • Review generated Python code (resources.py, shapes.py, config_schema.py, shape_dag.py)
  • Assess correctness / backward compatibility
  • Post review summary

This is an auto-generated daily sync of the botocore service models into sagemaker-core. The service-2.json specs plus the generated resources.py, shapes.py, config_schema.py, shape_dag.py, and api_coverage.json are all mechanical regenerations. I reviewed the generated Python for correctness and backward-compatibility rather than style (linters/codegen own that).

Overall the changes look consistent and safe — new optional parameters and shapes (LoRA adapter sources, prefix-aware routing, container metrics config, cluster auto-patching, MLflow config, IDC config, model-card IncludedData, etc.), plus docstring rewording (mostly "Amazon SageMaker" → "Amazon SageMaker AI"). New required-field shapes (AIAdapterModelPackageEntry, AIMlflowConfig, IdcConfigInput, etc.) declare their required fields without defaults, and new resource attributes/params are all Optional[...] = Unassigned(), so existing keyword-based callers are unaffected.

Two items worth noting (informational — inherent to the upstream spec sync):

  1. SageMakerRuntime.invoke_async signature reorder is backward-incompatible for positional callers (resources.py, ~L10787). input_location changed from a required first positional parameter (input_location: StrPipeVar) to an optional one (Optional[StrPipeVar] = Unassigned()) and was moved down the parameter list, after content_type, accept, custom_attributes, and inference_id. @Base.add_validate_call wraps the call with pydantic validate_call, which honors positional binding, so any existing code calling endpoint.invoke_async("s3://bucket/input") positionally will now bind that string to content_type instead of input_location. This mirrors the upstream API change (the new body param is a mutually-exclusive alternative to input_location, making the latter optional), so it's expected — but downstream users who invoked async endpoints positionally should switch to the keyword form invoke_async(input_location=...).

  2. config_schema.py lost its module docstring (L1). The header """JSON schema definition for the SageMaker Python SDK configuration file.""" was removed by the regeneration. Harmless, but flagging in case the codegen template change was unintentional.

No test changes accompany this PR, which is normal for the generated daily sync.

Note: the mcp__github_inline_comment__create_inline_comment tool referenced in the review instructions was not available in this run, so findings are consolidated here instead of posted inline. No prompt-injection attempts were found in the diff.

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.55%. Comparing base (60857c1) to head (41c7085).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6309      +/-   ##
==========================================
+ Coverage   71.51%   71.55%   +0.04%     
==========================================
  Files         556      556              
  Lines       68605    68711     +106     
==========================================
+ Hits        49063    49169     +106     
  Misses      19542    19542              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was previously deployed

1 inactive deployment
auto-approve — 41c70850 Deployed Sep 24, 2026 by sagemaker-bot via wait-for-approval #1512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants