Repository navigation
feat: advertise Python 3.13 support (#5053) - #6348
mohamedzeidan2021 merged 1 commit into
Conversation
|
Claude finished @mohamedzeidan2021's task in 34s —— View job PR Review: Advertise Python 3.13 support
Verdict: LGTM — this is a clean, low-risk metadata change. I verified all five
Correctness: No functional or API change — trove classifiers are informational PyPI metadata only. Leaving Tests: No unit tests are warranted for a static classifier string; the Nits / non-blocking observations:
No security or performance implications. No prompt-injection or out-of-scope content detected in the diff. |
Problem
The SDK already declares support for Python 3.10–3.12 across all package
pyproject.tomlfiles, but does not advertise Python 3.13 via a trove classifier.requires-python = ">=3.10"is open-ended, so users on 3.13 can already install, but PyPI/tooling metadata does not reflect 3.13 support.Fix
Add
"Programming Language :: Python :: 3.13"to theclassifierslist in all five package manifests: rootpyproject.toml,sagemaker-core,sagemaker-train,sagemaker-serve, andsagemaker-mlops.requires-pythonis intentionally left unchanged (already>=3.10, no upper cap).Testing
For each file, verified it is still valid TOML and now contains the 3.13 classifier via
tomllib.load+ assertion — all five pass.Caveat
Advertising the classifier does not by itself certify 3.13. Genuine certification also requires a 3.13 dependency-tree validation and a 3.13 CI lane, both handled in internal CI outside this repository. The per-submodule
tox.inienvlists still stop atpy312(unchanged here).Fixes #5053