Skip to content

change: update image_uri_configs - #6374

Merged
lucasjia-aws merged 3 commits into
masterfrom
master-rba-v3
Oct 2, 2026
Merged

lucasjia-aws merged 3 commits into
masterfrom
master-rba-v3

Conversation

@Yadan-Wei

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Claude finished @papriwal's task in 1m 29s —— View job


PR Review: change: update image_uri_configs

  • Read the PR diff (/tmp/pr.diff)
  • Analyze the config changes for correctness/backward-compat
  • Verify image_uris.retrieve behavior for region resolution
  • Post review

These are generated image_uri_config JSON updates (new container versions + added regional registries). JSON is well-formed and the additions follow the existing schema. One substantive concern and a couple of minor notes:

⚠️ pytorch-amzn2023.json — latest now points to 2.14, but 2.14 drops several partitions

version_aliases.latest is bumped 2.13 → 2.14 (diff line ~162), yet the new 2.14 registries block (diff lines ~228–264) is missing regions that the previous latest (2.13) supported:

  • GovCloud: us-gov-east-1, us-gov-west-1
  • ISO: us-iso-east-1, us-isob-east-1, us-isof-east-1, us-isof-south-1, eu-isoe-west-1
  • China: cn-north-1, cn-northwest-1
  • eusc-de-east-1

Because image_uris.retrieve(...) resolves a region through _registry_from_region → _validate_arg (sagemaker-core/src/sagemaker/core/image_uris.py:720-723), which raises ValueError for any region not present in the selected version's registries, callers in those partitions who request version="latest" (or omit the version and fall through to the alias) will now fail where 2.13 previously worked. This is a backward-incompatible change for those regions.

Please confirm this is intentional (i.e. the 2.14 images genuinely aren't published in GovCloud/ISO/China yet). If so, it may be worth keeping latest on 2.13 until 2.14 is available in those partitions, or documenting the gap — otherwise latest silently regresses for those partition users. Note that this same PR adds those partitions to the 2.11 and 2.13 blocks, which makes the omission in 2.14 stand out.

Minor

  • llama-cpp-arm64.json (diff lines ~9–81): the change inserts a new "1.0.0" entry near the top while renaming the pre-existing "1.0.0" block to "1.0.1" (cpu-v1.0.0 → cpu-v1.0.1). The net result is correct (a new 1.0.1 version, 1.0.0 content preserved), but the reorganization makes the diff harder to read than a plain append. No action needed if generated — just flagging that it's not a straightforward addition.
  • Several files (llama-cpp.json, sglang-server.json, vllm-omni.json, vllm-server.json) still have no trailing newline at EOF — pre-existing, not introduced here, so skip unless the repo lints for it.

The newly added sglang-server 1.4, vllm-omni 1.8, vllm-server 2.6, and sglang registry additions look consistent and introduce no alias changes, so they carry no backward-compat risk.

No security concerns (account IDs are the standard public DLC registry accounts; no credentials or user input involved).

@Yadan-Wei

Copy link
Copy Markdown
Contributor Author

The image uri update is correct, the new version is release to commercial regions for now, will add to special partition when it is ready.

@lucasjia-aws
lucasjia-aws merged commit 1a3cecf into master Oct 2, 2026
21 of 27 checks passed
@lucasjia-aws
lucasjia-aws deleted the master-rba-v3 branch October 2, 2026 22:17
@lucasjia-aws
lucasjia-aws restored the master-rba-v3 branch October 2, 2026 22:21
lucasjia-aws added a commit that referenced this pull request Oct 6, 2026
test_pytorch_amzn2023_training_uris compared the config's version list
against a hardcoded ["2.11", "2.12", "2.13"]. The automated
image_uri_configs update (#6374) added 2.14, so the exact-equality
assertion broke sagemaker-core unit tests on master.

Iterate over the versions present in the config, require a minimum set
of known versions, and check that the "latest" alias points to a
defined version, so future version additions do not break the test.

This branch was previously deployed

1 inactive deployment
auto-approve — 625bb916 Deployed Oct 12, 2026 by Yadan-Wei via wait-for-approval #2004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants