Skip to content

Daily Sync with Botocore v1.43.108 on 2026/10/05 - #6382

Closed
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-10-05-10-08-43
Closed

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-10-05-10-08-43

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 53s —— View job


PR Review: Daily Botocore Sync (v1.43.108)

  • Read PR diff
  • Analyze code changes (config_schema.py, resources.py, generated shapes)
  • Post review feedback

This is an auto-generated sync of the sagemaker-core botocore models. The bulk of the diff (service-2.json, shapes/shapes.py, shape_dag.py, api_coverage.json) is mechanical codegen — new shapes/fields and docstring text updated to "SageMaker AI". These look consistent and I have no concerns there. Most resources.py changes are purely additive (new Optional[...] = Unassigned() kwargs and docstrings), which are backward-compatible.

One thing worth flagging:

⚠️ Backward-incompatible signature change in Endpoint.invoke_async (sagemaker-core/src/sagemaker/core/resources.py, ~line 10787)

The sync reorders parameters and demotes input_location from a required positional arg to an optional keyword:

# before
def invoke_async(self, input_location: StrPipeVar, content_type=Unassigned(), accept=Unassigned(), ...):

# after
def invoke_async(self, content_type=Unassigned(), accept=Unassigned(),
                 custom_attributes=Unassigned(), inference_id=Unassigned(),
                 input_location: Optional[StrPipeVar] = Unassigned(),
                 s3_output_path_extension=Unassigned(), filename=Unassigned(),
                 ..., body: Optional[Any] = Unassigned(), ...):

This mirrors the upstream API change (InputLocation is now optional because the new mutually-exclusive Body param allows inline payloads). The additions themselves are fine, but note two effects for SDK consumers:

  1. Positional calls break silently. Any existing caller using endpoint.invoke_async("s3://bucket/input.json") will now bind that string to content_type instead of input_location, which fails at request time rather than raising a clear error. Callers using the keyword form (input_location=...) are unaffected.
  2. input_location is no longer enforced as required at the SDK layer — the mutual-exclusivity / "provide exactly one of Body or InputLocation" constraint is only validated server-side.

This is inherent to the codegen and matches botocore, so there's nothing to "fix" in this PR, but it's a semver-relevant behavior change that's worth calling out in release notes.

Minor

  • config_schema.py: the module docstring ("""JSON schema definition for the SageMaker Python SDK configuration file.""") was dropped by the generator. Harmless, but a small regression if the project's lint config expects module docstrings.

Notes

  • The inline-comment tool was not available in this run, so findings are consolidated here.
  • No security, credential-handling, or input-validation concerns in the changed code.
  • As generated code mirroring the service model, no new unit tests are expected for this PR.

Overall: looks good to merge as a routine model sync; just surface the invoke_async positional-arg behavior change in the changelog.

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.84%. Comparing base (1a3cecf) to head (129b475).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6382      +/-   ##
==========================================
+ Coverage   71.79%   71.84%   +0.04%     
==========================================
  Files         558      558              
  Lines       68834    68956     +122     
==========================================
+ Hits        49418    49540     +122     
  Misses      19416    19416              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was previously deployed

1 inactive deployment
auto-approve — 129b4754 Deployed Oct 5, 2026 by sagemaker-bot via wait-for-approval #527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants