Repository navigation
fix(core): don't send kms_key as an SSE-C key in S3Downloader.download - #6414
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
S3Downloader.download passed kms_key as extra_args={'SSECustomerKey': kms_key}.
SSECustomerKey is the SSE-C header, which expects a raw 256-bit customer key
plus SSECustomerAlgorithm, not a KMS key ARN, so every download with kms_key
failed with 400 Bad Request. S3 decrypts SSE-KMS objects transparently, so no
key is needed on GET.
This breaks DatasetBuilder.to_dataframe() for KMS-encrypted feature store
output, as reported in aws#4034 (closed, but the v3 code is unchanged).
Keep the kms_key parameter for backwards compatibility but no longer send it.
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with 
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Same bug as #4034, which was closed but the v3 code is unchanged.
Description of changes:
S3Downloader.downloadturnskms_keyintoextra_args={"SSECustomerKey": kms_key}.SSECustomerKeyis the SSE-C header: it expects a raw 256-bit customer key together withSSECustomerAlgorithm, not a KMS key ARN. Any download withkms_keyset therefore fails withClientError (400) HeadObject: Bad Request. S3 decrypts SSE-KMS objects transparently, so a GET doesn't need a key at all.This breaks
DatasetBuilder.to_dataframe()for KMS-encrypted feature store output.feature_utilsdownloads the query result with the dataset's KMS key.This change keeps the
kms_keyparameter for backwards compatibility, documents that it's unused, and stops sending it.Testing:
test_download_with_kms_keyasserted the SSE-C behaviour. It now expectsextra_args=None.tests/unit/s3: 105 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.