Repository navigation
fix(mlops): read disable_glue_table_creation from OfflineStoreConfig - #6416
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
create_athena_query and construct_feature_group_to_be_merged looked up disable_glue_table_creation on DataCatalogConfig, which has no such field (it is on OfflineStoreConfig), so the getattr default False was always used. Feature groups created with DisableGlueTableCreation=True and a custom DataCatalogConfig.Catalog were therefore always queried against AwsDataCatalog instead of their catalog. Read the flag from offline_store_config. The unit tests now use real OfflineStoreConfig/DataCatalogConfig shapes and cover both values.
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with 
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
create_athena_query(feature_utils.py) andconstruct_feature_group_to_be_merged(dataset_builder.py) look updisable_glue_table_creationonDataCatalogConfig:DataCatalogConfigonly hastable_name,cataloganddatabase.disable_glue_table_creationis a field ofOfflineStoreConfig, which is where v2 read it from. Thegetattrdefault is therefore always used. A feature group created withDisableGlueTableCreation=Trueand a customDataCatalogConfig.Catalogis always queried againstAwsDataCatalog.This change reads the flag from
fg.offline_store_config.Testing:
create_athena_queryandconstruct_feature_group_to_be_mergedtests usedMagicMockconfigs, which accept any attribute.OfflineStoreConfig/DataCatalogConfigshapes, parametrized over both flag values. TheTruecases fail before this change.tests/unit/sagemaker/mlops/feature_store: 391 passed.feature_processoralso happen on master.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.