Repository navigation
fix(mlops): stop waiting on CANCELLED Athena queries in wait_for_athena_query - #6417
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
…na_query wait_for_athena_query only stopped polling on SUCCEEDED or FAILED. CANCELLED is also a terminal Athena state, so waiting on a cancelled query (from the console, a workgroup limit, or StopQueryExecution) looped forever, hanging AthenaQuery.wait(), run_athena_query() and DatasetBuilder flows. Treat CANCELLED as terminal. Callers already raise for any state other than SUCCEEDED.
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with 
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
wait_for_athena_queryonly stops polling onSUCCEEDEDorFAILED.CANCELLEDis also a terminal Athena query state. Waiting on a query cancelled from the console, by a workgroup limit, or byStopQueryExecutionpolls every 5 seconds forever, which hangsAthenaQuery.wait(),run_athena_query()and theDatasetBuilderflows. v2 exited on any state other thanQUEUEDorRUNNING.This change treats
CANCELLEDas terminal.run_athena_queryandAthenaQueryalready raise for any state other thanSUCCEEDED, so a cancelled query now surfaces as an error.Testing:
TestWaitForAthenaQuery.test_returns_on_terminal_state, parametrized overSUCCEEDED,FAILEDandCANCELLED. TheCANCELLEDcase fails before this change.feature_utils,athena_queryanddataset_buildertests: 120 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.