Skip to content

fix(mlops): stop waiting on CANCELLED Athena queries in wait_for_athena_query #6417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkshayShah03 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(mlops): stop waiting on CANCELLED Athena queries in wait_for_athena_query #6417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sagemaker-mlops/src/sagemaker/mlops/feature_store/feature_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def wait_for_athena_query(session: Session, query_execution_id: str, poll: int =
state = get_query_execution(session, query_execution_id)["QueryExecution"]["Status"][
"State"
]
if state in ("SUCCEEDED", "FAILED"):
if state in ("SUCCEEDED", "FAILED", "CANCELLED"):
logger.info("Query %s %s.", query_execution_id, state.lower())
break
logger.info("Query %s is being executed.", query_execution_id)
Expand Down
17 changes: 17 additions & 0 deletions sagemaker-mlops/tests/unit/sagemaker/mlops/feature_store/test_feature_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
ingest_dataframe,
get_session_from_role,
_is_collection_column,
wait_for_athena_query,
)


Expand Down Expand Up @@ -201,6 +202,22 @@ def test_raises_when_no_metastore(self, mock_fg_class):
create_athena_query("my-fg", session)


class TestWaitForAthenaQuery:
@pytest.mark.parametrize("terminal_state", ["SUCCEEDED", "FAILED", "CANCELLED"])
@patch("sagemaker.mlops.feature_store.feature_utils.time.sleep")
@patch("sagemaker.mlops.feature_store.feature_utils.get_query_execution")
def test_returns_on_terminal_state(self, mock_get, mock_sleep, terminal_state):
mock_get.side_effect = [
{"QueryExecution": {"Status": {"State": "RUNNING"}}},
{"QueryExecution": {"Status": {"State": terminal_state}}},
]

wait_for_athena_query(Mock(), "query-id", poll=1)

assert mock_get.call_count == 2
mock_sleep.assert_called_once_with(1)


class TestIngestDataframe:
@patch("sagemaker.mlops.feature_store.feature_utils.IngestionManagerPandas")
@patch("sagemaker.mlops.feature_store.feature_utils.CoreFeatureGroup")
Expand Down
Loading