Repository navigation
fix(core): read container image from the Model resource in Transformer - #6418
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
Transformer._retrieve_image_uri called getattr() on model.__dict__, a plain dict, so it always got the default and returned None. Auto-generated transform job names therefore always fell back to the model name instead of the image's algorithm name. Read primary_container/containers from the Model resource itself. The unit tests used a dict subclass with attribute access as __dict__, which hid the bug; they now use real Model/ContainerDefinition objects.
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with 
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Transformer._retrieve_image_uricallsgetattronmodel.__dict__, which is a plain dict:getattron a dict always returns the default, so the method always returnsNone. Auto-generated transform job names therefore always fall back to the model name instead of the image's algorithm name.This change reads
primary_containerandcontainersfrom theModelresource itself.Testing:
_retrieve_image_uritests replaced__dict__with a dict subclass that supports attribute access, which hid the bug.Model/ContainerDefinitionobjects and fail before this change.tests/unit/test_transformer.py: 30 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.