Repository navigation
fix(core): build a v3 ProcessingOutput in ModelMonitor._normalize_processing_output - #6422
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
…cessing_output ModelMonitor.run_baseline(output=<str>) normalizes the string through _normalize_processing_output, which still built the output with the v2 ProcessingOutput(source=..., destination=...) signature. The v3 ProcessingOutput shape has no such fields (extra='forbid'), so every run_baseline call with a string output raised a pydantic ValidationError. Build it with output_name and an s3_output (ProcessingS3Output) instead, keeping the v2 meaning: the string is the container path and the S3 destination is generated.
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with 
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
ModelMonitor.run_baseline(baseline_inputs, output=<str>)normalizes a stringoutputthrough_normalize_processing_output. That method still builds the output with the v2 signature:The v3
ProcessingOutputshape has nosourceordestinationfields (extra="forbid"). Everyrun_baselinecall with a string output therefore raises:This change builds the output with
output_nameand ans3_output=ProcessingS3Output(s3_uri=..., local_path=..., s3_upload_mode="EndOfJob"), the same way_normalize_baseline_outputright above it does. The v2 meaning is unchanged: the string is the container path, and the S3 destination is generated.Testing:
test_normalize_processing_output_from_local_path. It fails before this change.tests/unit/test_model_monitoring.pyandtests/unit/model_monitor: 90 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.