Repository navigation
fix(mlops): stop PipelineExecution.wait() on a Stopped execution - #6423
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
The PipelineExecutionComplete waiter only had acceptors for Succeeded and Failed. Stopped is also a terminal pipeline execution status, so waiting on a stopped execution kept polling until max_attempts (30 minutes by default) and then failed with 'Max attempts exceeded'. result() swallows terminal failures but not that error, so it raised too instead of reporting the step. Treat Stopped as a terminal failure, like Failed.
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with 
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The
PipelineExecutionCompletewaiter used byPipelineExecution.wait()only has acceptors forSucceededandFailed.Stoppedis also a terminal pipeline execution status, so waiting on a stopped execution keeps polling untilmax_attemptsand then fails withMax attempts exceeded. With the defaults (delay=30,max_attempts=60) that takes 30 minutes.PipelineExecution.result()swallows terminal-failureWaiterErrors and goes on to report the step's status. It doesn't swallow the max-attempts error, so for a stopped execution it raised after the full wait instead.This change adds a
Stoppedacceptor withstate: failure, likeFailed.Testing:
test_pipeline_execution_wait_stops_on_terminal_failure, parametrized overFailedandStopped. It runs the real botocore waiter against a stubbed client and asserts there is exactly one describe call.Stoppedcase fails before this change.sagemaker-mlops/tests/unit/workflow: 361 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.