Repository navigation
fix(core): use self.boto_session for the custom S3 endpoint in LocalSession - #6424
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
…ession LocalSession._initialize falls back to boto3.Session() when no boto_session is passed, but the s3_endpoint_url branch then created the S3 resource and client from the boto_session argument instead of self.boto_session. So LocalSession(s3_endpoint_url=...) without an explicit boto session failed with AttributeError: 'NoneType' object has no attribute 'resource'.
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with 
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
LocalSession._initializefalls back toboto3.Session()when noboto_sessionis passed. Thes3_endpoint_urlbranch, however, builds the S3 resource and client from theboto_sessionargument instead ofself.boto_session:So
LocalSession(s3_endpoint_url="http://localhost:9000")without an explicit boto session fails withAttributeError: 'NoneType' object has no attribute 'resource'.This change uses
self.boto_session, as the non-endpoint branch already does.Testing:
test_local_session_with_s3_endpoint_and_default_boto_session. It fails before this change.tests/unit/local: 177 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.