Repository navigation
fix(core): pass processing arguments without a custom entrypoint in local mode - #6425
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
…ocal mode For local processing jobs, _create_docker_host appended container_arguments to host_config['entrypoint'], which is only set when a container_entrypoint is given. A processing job with arguments but no entrypoint (valid in the API: ContainerArguments without ContainerEntrypoint runs the image's own entrypoint) therefore failed with KeyError: 'entrypoint'. When there is no custom entrypoint, pass the arguments as the compose 'command' so they reach the image's entrypoint.
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with 
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
For local processing jobs,
_SageMakerContainer._create_docker_hostappendscontainer_argumentstohost_config["entrypoint"]:host_config["entrypoint"]is only set when acontainer_entrypointis given. The API allowsContainerArgumentswithoutContainerEntrypoint, in which case the image's own entrypoint runs. A local-mode processing job with arguments but no entrypoint therefore fails withKeyError: 'entrypoint'.This change passes the arguments as the compose
commandwhen there's no custom entrypoint, so they reach the image's entrypoint. Behaviour with an entrypoint is unchanged.Testing:
test_create_docker_host_processing_entrypoint_and_arguments, covering arguments only, entrypoint only, and both. The arguments-only case fails before this change.tests/unit/local: 179 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.