Repository navigation
fix(mlops): raise when the FeatureGroupManager.update() API call fails - #6443
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
FeatureGroupManager.update() caught every exception from the parent FeatureGroup.update() (UpdateFeatureGroup), logged it and carried on: the Iceberg property update still ran and the method returned self as if the update had succeeded. ValidationException, ResourceInUse, AccessDenied and similar errors were therefore only visible in the logs. The Iceberg branch right below already re-raises after logging. Re-raise after logging, so the caller sees the failure and the Iceberg properties are not updated on a failed update.
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
FeatureGroupManager.update()catches every exception from the parentFeatureGroup.update(), which callsUpdateFeatureGroup, logs it, and carries on:The Iceberg property update then still runs, and the method returns
selfas if the update had succeeded. SoValidationException,ResourceInUse,AccessDeniedand similar errors only show up in the logs. The Iceberg branch right below already re-raises after logging.This change re-raises after logging, so the caller sees the failure and the Iceberg properties aren't changed when the update fails.
Testing:
test_parent_update_failure_is_raised: theClientErrorpropagates and_update_iceberg_propertiesisn't called. It fails before this change.tests/unit/sagemaker/mlops/feature_store: 390 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.