Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def retrieve_hugging_face_uri(
pt_or_tf_version = (
re.compile("^(pytorch|tensorflow)(.*)$").match(base_framework_version).group(2)
)
_version = original_version
_version = _version_for_config(version, config)

if repo in [
"huggingface-pytorch-trcomp-training",
Expand Down
30 changes: 30 additions & 0 deletions sagemaker-core/tests/unit/test_image_retriever.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,3 +260,33 @@ def test_retrieve_jumpstart_uri_not_implemented(self):
# This method currently has no implementation
result = ImageRetriever.retrieve_jumpstart_uri()
assert result is None


def test_retrieve_hugging_face_uri_resolves_version_alias_like_image_uris():
"""The transformers version in the tag is resolved through the alias map (see #5722)."""
from sagemaker.core import image_uris

kwargs = dict(
region="us-west-2",
version="4.26",
base_framework_version="pytorch1.13",
instance_type="ml.g5.xlarge",
image_scope="inference",
)

uri = ImageRetriever.retrieve_hugging_face_uri(**kwargs)

assert uri == image_uris.retrieve("huggingface", **kwargs)
assert "-transformers4.26.0-" in uri


def test_retrieve_hugging_face_uri_without_version_uses_selected_version():
uri = ImageRetriever.retrieve_hugging_face_uri(
region="us-west-2",
base_framework_version="pytorch2.6",
instance_type="ml.g5.xlarge",
image_scope="inference",
py_version="py312",
)

assert "transformersNone" not in uri
Loading