Repository navigation
fix: honor request content types - #6463
Open
lucasjia-aws wants to merge 1 commit into
Open
lucasjia-aws wants to merge 1 commit into
lucasjia-aws wants to merge 1 commit into
Conversation
Pass caller-provided content types to request deserializers so JSON and CSV NumPy payloads are decoded correctly. Keep response deserializers pinned to configured Accept types for model servers that return misleading headers. Fixes aws#5006
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeserializerWrappercurrently forces its configured Accept type for both request and response deserialization. As a result, valid JSON or CSV requests can be incorrectly parsed as NPY data.This change makes input deserializers honor the caller-provided Content-Type while preserving the existing output behavior that uses the configured Accept type when model servers return misleading response headers such as
text/html.Testing
text/htmlresponse still uses the configured NPY deserializer.git diff --checkpassed.Related change
The companion V3 fix is published on #6462.
Fixes #5006