Repository navigation
fix: make feature ingestion spawn-safe - #6465
Open
lucasjia-aws wants to merge 1 commit into
Open
lucasjia-aws wants to merge 1 commit into
lucasjia-aws wants to merge 1 commit into
Conversation
Create the pathos processing pool with a local multiprocess spawn context and move worker callables to module scope for pickling. Preserve the existing amap, restart, close, and clear lifecycle. Fixes aws#5312
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Feature Store pandas ingestion currently uses the pathos processing pool with the platform default start method and local worker callables. Fork mode can deadlock on recent macOS releases, while the local initializer and lambda are unsafe under spawn.
This change supplies an explicit multiprocess spawn context to the pathos pool and moves the initializer and worker wrapper to module scope. Existing
amap, restart, close, and clear lifecycle behavior is preserved.Testing
git diff --checkpassed.Related change
The companion V3 fix is published on #6464.
Fixes #5312