Skip to content

Daily Sync with Botocore v1.43.114 on 2026/10/19 - #6498

Closed
sagemaker-bot wants to merge 2 commits into
masterfrom
botocore-sync-2026-10-19-10-06-00
Closed

sagemaker-bot wants to merge 2 commits into
masterfrom
botocore-sync-2026-10-19-10-06-00

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI code review

Automated daily botocore sync (v1.43.114) regenerating the generated layers (resources.py, shapes.py, shape_dag.py, config_schema.py, sample service JSON, api_coverage.json). Changes are predominantly additive and consistent across files: new invoke/invoke_with_response_stream prefix_aware_id, invoke_async s3_output_path_extension/filename/body, new pipeline step metadata shapes (Athena, Cleanup, EMRServerless, ForEach, IterationContext), ConflictException relocation, and a new CompletedWithFailures pipeline status. New shapes referenced in resources.py/shape_dag.py are defined in shapes.py; scalar header shapes follow the existing convention of not needing standalone DAG entries. The only reviewable concern is the backward-incompatible positional reorder of Endpoint.invoke_async, consistent with prior sync PRs — worth a release-note call-out. No unit tests are expected for a pure generated-layer sync.

Reviewed commit 58278e9. Automated review; verify before acting.

def invoke_async(
self,
input_location: StrPipeVar,
content_type: Optional[StrPipeVar] = Unassigned(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Medium: invoke_async reorders its signature: input_location was the required first positional parameter and is now an optional keyword (Unassigned()) moved after content_type/accept/custom_attributes/inference_id. This is backward-incompatible for any caller passing arguments positionally (e.g. endpoint.invoke_async("s3://.../input") now binds the value to content_type). This faithfully mirrors the upstream botocore change where Body and InputLocation became mutually exclusive, but it should be called out in the release notes.

Source: #6454
Source: #6365

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.20%. Comparing base (9e503c9) to head (58278e9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6498      +/-   ##
==========================================
+ Coverage   73.19%   73.20%   +0.01%     
==========================================
  Files         572      572              
  Lines       71767    71803      +36     
==========================================
+ Hits        52527    52563      +36     
  Misses      19240    19240              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI code review

Automated daily botocore sync (v1.43.114). Changes are code-generated across service-2.json models, resources.py, shapes.py, shape_dag.py, config_schema.py, and api_coverage.json. Additions are largely new optional shapes/parameters (Athena/Cleanup/EMRServerless/ForEach step metadata, IterationContext, prefix_aware_id, async body/filename/s3_output_path_extension, CompletedWithFailures wait status) plus doc rewording ("SageMaker" → "SageMaker AI"). I verified shape wiring is consistent across the three generated files, the relocated ConflictException has no duplicate, and the new scalar header/blob shapes follow the established DAG convention. The only functional risk is the Endpoint.invoke_async signature reorder, consistent with prior syncs. Overall the PR looks clean for a generated sync.

Reviewed commit de7d35b. Automated review; verify before acting.

def invoke_async(
self,
input_location: StrPipeVar,
content_type: Optional[StrPipeVar] = Unassigned(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Medium: Endpoint.invoke_async reorders its signature: input_location changes from a required first positional argument to an optional keyword argument (now defaulting to Unassigned() and placed after content_type, accept, custom_attributes, inference_id). This is backward-incompatible for any caller using the positional form invoke_async(input_s3_path) — it will now be interpreted as content_type. Keyword callers (invoke_async(input_location=...)) are unaffected, and the in-repo example notebook already uses the keyword form. This faithfully mirrors the upstream botocore change (Body and InputLocation are now mutually exclusive), but per prior sync reviews it should be called out in the release notes as a breaking change for positional callers. Source: #6454

This branch was successfully deployed

1 active deployment
auto-approve — de7d35be Deployed Oct 22, 2026 by rsareddy0329 via wait-for-approval #2086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants