Repository navigation
Daily Sync with Botocore v1.43.114 on 2026/10/19 - #6498
sagemaker-bot wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🤖 AI code review
Automated daily botocore sync (v1.43.114) regenerating the generated layers (resources.py, shapes.py, shape_dag.py, config_schema.py, sample service JSON, api_coverage.json). Changes are predominantly additive and consistent across files: new invoke/invoke_with_response_stream prefix_aware_id, invoke_async s3_output_path_extension/filename/body, new pipeline step metadata shapes (Athena, Cleanup, EMRServerless, ForEach, IterationContext), ConflictException relocation, and a new CompletedWithFailures pipeline status. New shapes referenced in resources.py/shape_dag.py are defined in shapes.py; scalar header shapes follow the existing convention of not needing standalone DAG entries. The only reviewable concern is the backward-incompatible positional reorder of Endpoint.invoke_async, consistent with prior sync PRs — worth a release-note call-out. No unit tests are expected for a pure generated-layer sync.
Reviewed commit 58278e9. Automated review; verify before acting.
| def invoke_async( | ||
| self, | ||
| input_location: StrPipeVar, | ||
| content_type: Optional[StrPipeVar] = Unassigned(), |
There was a problem hiding this comment.
🟠 Medium: invoke_async reorders its signature: input_location was the required first positional parameter and is now an optional keyword (Unassigned()) moved after content_type/accept/custom_attributes/inference_id. This is backward-incompatible for any caller passing arguments positionally (e.g. endpoint.invoke_async("s3://.../input") now binds the value to content_type). This faithfully mirrors the upstream botocore change where Body and InputLocation became mutually exclusive, but it should be called out in the release notes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6498 +/- ##
==========================================
+ Coverage 73.19% 73.20% +0.01%
==========================================
Files 572 572
Lines 71767 71803 +36
==========================================
+ Hits 52527 52563 +36
Misses 19240 19240 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🤖 AI code review
Automated daily botocore sync (v1.43.114). Changes are code-generated across service-2.json models, resources.py, shapes.py, shape_dag.py, config_schema.py, and api_coverage.json. Additions are largely new optional shapes/parameters (Athena/Cleanup/EMRServerless/ForEach step metadata, IterationContext, prefix_aware_id, async body/filename/s3_output_path_extension, CompletedWithFailures wait status) plus doc rewording ("SageMaker" → "SageMaker AI"). I verified shape wiring is consistent across the three generated files, the relocated ConflictException has no duplicate, and the new scalar header/blob shapes follow the established DAG convention. The only functional risk is the Endpoint.invoke_async signature reorder, consistent with prior syncs. Overall the PR looks clean for a generated sync.
Reviewed commit de7d35b. Automated review; verify before acting.
| def invoke_async( | ||
| self, | ||
| input_location: StrPipeVar, | ||
| content_type: Optional[StrPipeVar] = Unassigned(), |
There was a problem hiding this comment.
🟠 Medium: Endpoint.invoke_async reorders its signature: input_location changes from a required first positional argument to an optional keyword argument (now defaulting to Unassigned() and placed after content_type, accept, custom_attributes, inference_id). This is backward-incompatible for any caller using the positional form invoke_async(input_s3_path) — it will now be interpreted as content_type. Keyword callers (invoke_async(input_location=...)) are unaffected, and the in-repo example notebook already uses the keyword form. This faithfully mirrors the upstream botocore change (Body and InputLocation are now mutually exclusive), but per prior sync reviews it should be called out in the release notes as a breaking change for positional callers. Source: #6454
Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.