Skip to content

fix: add g7e, p6-b200 and trn2 to volume size unsupported instance families - #6505

Merged
mufaddal-rohawala merged 2 commits into
aws:masterfrom
cj-zhang:fix/volume-size-unsupported-families
Oct 20, 2026
Merged

mufaddal-rohawala merged 2 commits into
aws:masterfrom
cj-zhang:fix/volume-size-unsupported-families

Conversation

@cj-zhang

Copy link
Copy Markdown
Collaborator

Issue #, if available:

  • JumpStart deployment for gpt-oss-120b is FAILING because the deployment config sets volume size for an NVME-backed instance

Description of changes:

  • Update the list of EBS-unsupported instance families

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…milies

---
X-AI-Prompt: Add g7e, p6-b200, and trn2 to volume size unsupported instances
X-AI-Tool: Claude
@cj-zhang
cj-zhang deployed to auto-approve October 20, 2026 17:39 — with GitHub Actions Active
@cj-zhang
cj-zhang deployed to auto-approve October 20, 2026 17:39 — with GitHub Actions Active
@cj-zhang
cj-zhang deployed to auto-approve October 20, 2026 17:39 — with GitHub Actions Active

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI code review

This PR adds g7e, p6-b200, and trn2 to the unsupported_families list in volume_size_supported(), so the SDK no longer passes volume size for these NVMe-backed instances. The change is minimal, consistent with the pattern established in PR #4828 (Source: #4828), updates the accompanying comment, and includes a parametrized unit test covering the three new families. Looks clean; no issues found.

Reviewed commit e4f161c. Automated review; verify before acting.

…nit tests

---
X-AI-Prompt: Run formatters and fix issues
X-AI-Tool: Claude

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI code review

This PR adds g7e, p6-b200, and trn2 to the list of instance families that don't support EBS volume attachment in volume_size_supported(), fixing JumpStart deployment failures for NVMe-backed instances. The change follows the pattern established in PR #4828 (Source: #4828) and includes a parametrized test covering the new families. The remaining diff hunks are black reformatting of unrelated test files. The change is correct and adequately tested; no issues found.

Reviewed commit af314ab. Automated review; verify before acting.

@mufaddal-rohawala
mufaddal-rohawala merged commit 61213e9 into aws:master Oct 20, 2026
30 checks passed

This branch was successfully deployed

1 active deployment
auto-approve — af314ab4 Deployed Oct 20, 2026 by cj-zhang via wait-for-approval #2065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants