Skip to content

test(serve): run the recommender integ tests on ml.g6 and ml.g7 instances - #6557

Merged
papriwal merged 1 commit into
aws:masterfrom
ZealSV:test/air-integ-g7
Nov 4, 2026
Merged

papriwal merged 1 commit into
aws:masterfrom
ZealSV:test/air-integ-g7

Conversation

@ZealSV

@ZealSV ZealSV commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

test_recommendation_workflow_end_to_end's recommendation job, and the endpoint the test deploys from its top recommendation, now use ml.g7.2xlarge instead of ml.g5.2xlarge.

The JumpStart model, which the benchmark test deploys and the recommendation test builds, now uses ml.g6.2xlarge: JumpStart has no ml.g7 image configuration for it, and ml.g6.2xlarge gets the same serving image as ml.g5.2xlarge.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@papriwal papriwal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review of the recommender integ test change. One suggestion, inline below: the model builder now targets ml.g6.2xlarge while the recommendation job targets ml.g7.2xlarge, and nothing after the deploy confirms which of the two the endpoint runs on. The inline comment proposes an assertion on the endpoint config.

…nces

test_recommendation_workflow_end_to_end's recommendation job, and the
endpoint the test deploys from its top recommendation, now use
ml.g7.2xlarge instead of ml.g5.2xlarge.

The JumpStart model, which the benchmark test deploys and the
recommendation test builds, now uses ml.g6.2xlarge: JumpStart has no
ml.g7 image configuration for it, and ml.g6.2xlarge gets the same
serving image as ml.g5.2xlarge.
@ZealSV
ZealSV force-pushed the test/air-integ-g7 branch from 5554b37 to 3f0ecea Compare November 4, 2026 18:46
@ZealSV
ZealSV deployed to manual-approval November 4, 2026 18:47 — with GitHub Actions Active
@ZealSV
ZealSV deployed to manual-approval November 4, 2026 18:47 — with GitHub Actions Active
@ZealSV
ZealSV deployed to manual-approval November 4, 2026 18:47 — with GitHub Actions Active

@papriwal papriwal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI code review

This PR updates the AI inference recommender integ test to run on newer instance families: the JumpStart model builder now uses ml.g6.2xlarge and the recommendation job/endpoint use ml.g7.2xlarge. It also adds an assertion that the deployed endpoint config's production variant instance type matches the requested recommendation instance type. All three prior usages of the renamed INSTANCE_TYPE constant are correctly updated, and the change is self-consistent. No issues found.

Reviewed commit 3f0ecea. Automated review; verify before acting.

@papriwal
papriwal merged commit b4b0b80 into aws:master Nov 4, 2026
22 of 24 checks passed

This branch was successfully deployed

1 active deployment
manual-approval — 3f0eceab Deployed Nov 4, 2026 by ZealSV via wait-for-approval #806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants