Skip to content

Added support for env variables in helm chart - #504

Open
stijndehaes wants to merge 4 commits into
aws:mainfrom
stijndehaes:feature/env-variable-support-helm
Open

Added support for env variables in helm chart#504
stijndehaes wants to merge 4 commits into
aws:mainfrom
stijndehaes:feature/env-variable-support-helm

Conversation

@stijndehaes

Copy link
Copy Markdown

Issue #, if available: None

Description of changes:

Added support for environment variables in the helm chart

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stijndehaes
stijndehaes requested a review from a team as a code owner August 21, 2025 09:46
@codecov

codecov Bot commented Aug 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.56%. Comparing base (1e5ab37) to head (8ce2197).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   61.56%   61.56%           
=======================================
  Files          11       11           
  Lines         752      752           
=======================================
  Hits          463      463           
  Misses        274      274           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simonmarty

Copy link
Copy Markdown
Contributor

What's the use case for this?

@namnguyen-tmr

namnguyen-tmr commented Feb 25, 2026

Copy link
Copy Markdown

We have a use case where we want to disable IMDS service, .i.e set AWS_EC2_METADATA_DISABLED to true. Can we add support for this please

@stijndehaes

Copy link
Copy Markdown
Author

We set the KUBERNETES_SERVICE_HOST to the AWS URL instaed of using the internal service, this improves reliability because at some point we were seeing issues with the internal service.

env:
- name: KUBERNETES_SERVICE_HOST
  value: ${var.kubernetes_host}

Signed-off-by: Simon Marty <simon.marty@protonmail.com>
simonmarty
simonmarty previously approved these changes Feb 27, 2026
Signed-off-by: Simon Marty <simon.marty0@gmail.com>
@namnguyen-tmr

Copy link
Copy Markdown

@simonmarty Any timeline for this to be merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants