fix: cleanup scripts skip DEFAULT endpoint to prevent resource leaks - #2007
Open
jyotsnamas wants to merge 2 commits into
Open
fix: cleanup scripts skip DEFAULT endpoint to prevent resource leaks#2007jyotsnamas wants to merge 2 commits into
jyotsnamas wants to merge 2 commits into
Conversation
The AgentCore API now auto-manages DEFAULT endpoints — they cannot be explicitly deleted. cleanup.py scripts that attempt to delete all endpoints (including DEFAULT) get a ConflictException, which then prevents the runtime from being deleted. Resources are leaked despite the script reporting "Cleanup complete". Fix: Skip DEFAULT endpoints during explicit deletion, matching the pattern already used in 01-strands-bedrock/cleanup.py. Also fixes the observability cleanup which used wrong parameter name (name= instead of endpointName=). Verified by live deployment testing: deploy → invoke → cleanup now succeeds without leaking runtimes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Latest scan for commit: Security Scan ResultsScan Metadata
SummaryScanner ResultsThe table below shows findings by scanner, with status based on severity thresholds and dependencies: Column Explanations: Severity Levels (S/C/H/M/L/I):
Other Columns:
Scanner Results:
Severity Thresholds (Thresh Column):
Threshold Source: Values in parentheses indicate where the threshold is configured:
Statistics calculation:
|
Replace broad `except Exception` with `except ClientError` from botocore.exceptions, replace bare `pass` with informative print statements, and fix import sorting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanup.pyscripts that silently leak AgentCore runtimes and endpointsConflictException, which then prevents runtime deletionRoot cause
Fix
Skip DEFAULT endpoints during explicit deletion, matching the pattern already used in
01-strands-bedrock/cleanup.py:Verification
Deployed and cleaned up multiple modules in us-west-2:
aws bedrock-agentcore-control list-agent-runtimesshows runtime still READY after cleanupTest plan
🤖 Generated with Claude Code