This repository was archived by the owner on Sep 2, 2026. It is now read-only.
fix(ci): resolve TypeScript build failures and upgrade Node.js to 18 - #278
Closed
AoyuQC wants to merge 1 commit into
Closed
fix(ci): resolve TypeScript build failures and upgrade Node.js to 18#278AoyuQC wants to merge 1 commit into
AoyuQC wants to merge 1 commit into
Conversation
…4 to 18 - Add skipLibCheck to tsconfig.json and tsconfig.jest.json to fix @types/node Buffer compatibility errors breaking JS dependency PRs - Upgrade test-cdk.yml from Node.js 14 (EOL) to Node.js 18 - Update all GitHub Actions to v4 (checkout, setup-node) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #279 which includes all these CI fixes plus the CDK upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipLibCheck: truetotsconfig.jsonandtsconfig.jest.json— fixes the@types/nodeBuffer/Uint8Array compatibility errors (TS2430,TS2344) that are causing build failures on all JS dependency update PRs (chore(deps-dev): bump lodash from 4.17.21 to 4.17.23 in /source #273, chore(deps): bump @smithy/config-resolver and @aws-sdk/client-cloudformation in /source #272, chore(deps): bump js-yaml in /source #268)test-cdk.yml— Node 14 reached EOL on 2023-04-30 and is no longer supported by modern CDK versionsactions/checkout,actions/setup-node) across all JS workflows for consistency and securityContext
All 3 JavaScript Dependabot PRs (#273 lodash, #272 @smithy/config-resolver, #268 js-yaml) are blocked by the same TypeScript compilation error in
node_modules/@types/node/buffer.d.ts. This is a known incompatibility between newer@types/nodedefinitions and the project's TypeScript version. AddingskipLibCheck: trueis the standard fix — it skips type-checking of.d.tsfiles innode_modules, which are not the project's responsibility to validate.PRs unblocked by this change
Once merged, the following PRs should be rebased and will pass CI:
lodash4.17.21 → 4.17.23@smithy/config-resolver+@aws-sdk/client-cloudformationjs-yamlTest plan
🤖 Generated with Claude Code