fix(lint): fix all golangci-lint issues

- Remove 5 unused Player methods (getProperty, getStringProperty, etc.)
- Fix capitalized error strings in pulseaudio (ST1005)
- Merge variable declaration with assignment in systemd (S1021)
- Fix unchecked Close() errors by logging them with logger.Info()
  - api/json.go: r.Body.Close()
  - backend/systemd/listener.go: conn.Close() and watcher.Close()

All tests pass with 17.8% coverage.
golangci-lint reports 0 issues.

https://claude.ai/code/session_011G1Zfk4MvfH6TyvAPWSjxq

Author: claude

api/json.go

@@ -4,6 +4,8 @@ import (
 	"encoding/json"
 	"errors"
 	"net/http"
+
+	"github.com/b0bbywan/go-odio-api/logger"
 )
 
 type setVolumeRequest struct {
@@ -30,7 +32,11 @@ func withBody[T any](
 	next func(w http.ResponseWriter, r *http.Request, req *T),
 ) http.HandlerFunc {
 	return func(w http.ResponseWriter, r *http.Request) {
-		defer r.Body.Close()
+		defer func() {
+			if err := r.Body.Close(); err != nil {
+				logger.Info("Failed to close request body: %v", err)
+			}
+		}()
 
 		var req T
 		if err := json.NewDecoder(r.Body).Decode(&req); err != nil {

backend/mpris/dbus.go

@@ -160,44 +160,3 @@ func (p *Player) getAllProperties(iface string) (map[string]dbus.Variant, error)
 	err := call.Store(&props)
 	return props, err
 }
-
-// getProperty récupère une propriété D-Bus via le backend
-func (p *Player) getProperty(iface, prop string) (dbus.Variant, error) {
-	return p.backend.getProperty(p.BusName, iface, prop)
-}
-
-// getStringProperty récupère une propriété string
-func (p *Player) getStringProperty(iface, prop string) (string, bool) {
-	v, err := p.getProperty(iface, prop)
-	if err != nil {
-		return "", false
-	}
-	return extractString(v)
-}
-
-// getBoolProperty récupère une propriété bool
-func (p *Player) getBoolProperty(iface, prop string) (bool, bool) {
-	v, err := p.getProperty(iface, prop)
-	if err != nil {
-		return false, false
-	}
-	return extractBool(v)
-}
-
-// getFloat64Property récupère une propriété float64
-func (p *Player) getFloat64Property(iface, prop string) (float64, bool) {
-	v, err := p.getProperty(iface, prop)
-	if err != nil {
-		return 0, false
-	}
-	return extractFloat64(v)
-}
-
-// getInt64Property récupère une propriété int64
-func (p *Player) getInt64Property(iface, prop string) (int64, bool) {
-	v, err := p.getProperty(iface, prop)
-	if err != nil {
-		return 0, false
-	}
-	return extractInt64(v)
-}

backend/pulseaudio/pulseaudio.go

@@ -293,7 +293,7 @@ func (pa *PulseAudioBackend) Close() {
 
 func (pa *PulseAudioBackend) ToggleMuteMaster() error {
 	if _, err := pa.client.ToggleMute(); err != nil {
-		return fmt.Errorf("Failed to get default sink: %w", err)
+		return fmt.Errorf("failed to get default sink: %w", err)
 	}
 	return nil
 }
@@ -306,7 +306,7 @@ func (pa *PulseAudioBackend) ToggleMute(name string) error {
 	logger.Debug("[pulseaudio] toggling mute for client %q", name)
 	sink, err := pa.client.GetSinkInputByName(name)
 	if err != nil {
-		return fmt.Errorf("Failed to get Sink Input: %w", err)
+		return fmt.Errorf("failed to get sink input: %w", err)
 	}
 
 	if err := sink.ToggleMute(); err != nil {
@@ -319,7 +319,7 @@ func (pa *PulseAudioBackend) SetVolume(name string, vol float32) error {
 	logger.Debug("[pulseaudio] setting volume for client %q to %.2f", name, vol)
 	sink, err := pa.client.GetSinkInputByName(name)
 	if err != nil {
-		return fmt.Errorf("Failed to get Sink Input: %w", err)
+		return fmt.Errorf("failed to get sink input: %w", err)
 	}
 
 	if err := sink.SetVolume(vol); err != nil {

backend/systemd/listener.go

@@ -82,7 +82,9 @@ func (l *Listener) startScope(scope UnitScope, watched map[string]bool) error {
 	matchRule := "type='signal',sender='org.freedesktop.systemd1'"
 
 	if err := conn.BusObject().Call("org.freedesktop.DBus.AddMatch", 0, matchRule).Err; err != nil {
-		conn.Close()
+		if closeErr := conn.Close(); closeErr != nil {
+			logger.Info("Failed to close D-Bus connection: %v", closeErr)
+		}
 		return err
 	}
 	ch := make(chan *dbus.Signal, 10)
@@ -96,9 +98,7 @@ func (l *Listener) startScope(scope UnitScope, watched map[string]bool) error {
 
 func (l *Listener) checkUnit(sig *dbus.Signal, scope UnitScope) (string, bool) {
 	// Extraire le nom de l'unité depuis le path
-	var unitName string
-
-	unitName = unitNameFromPath(sig.Path)
+	unitName := unitNameFromPath(sig.Path)
 	if unitName == "" {
 		return unitName, false
 	}
@@ -162,7 +162,11 @@ func (l *Listener) listen(
 	scope UnitScope,
 	watched map[string]bool,
 ) {
-	defer conn.Close()
+	defer func() {
+		if err := conn.Close(); err != nil {
+			logger.Info("Failed to close D-Bus connection: %v", err)
+		}
+	}()
 
 	for {
 		select {
@@ -200,12 +204,16 @@ func (l *Listener) StartHeadless() error {
 
 	// Vérifier que le répertoire existe
 	if _, err := os.Stat(unitsDir); os.IsNotExist(err) {
-		watcher.Close()
+		if closeErr := watcher.Close(); closeErr != nil {
+			logger.Info("Failed to close watcher: %v", closeErr)
+		}
 		return fmt.Errorf("units directory does not exist: %s", unitsDir)
 	}
 
 	if err := watcher.Add(unitsDir); err != nil {
-		watcher.Close()
+		if closeErr := watcher.Close(); closeErr != nil {
+			logger.Info("Failed to close watcher: %v", closeErr)
+		}
 		return err
 	}
 
@@ -217,7 +225,11 @@ func (l *Listener) StartHeadless() error {
 }
 
 func (l *Listener) listenHeadless(watcher *fsnotify.Watcher) {
-	defer watcher.Close()
+	defer func() {
+		if err := watcher.Close(); err != nil {
+			logger.Info("Failed to close watcher: %v", err)
+		}
+	}()
 
 	for {
 		select {