Skip to content

Commit 16d1351

Browse files
committed
Say the launch label stays on the token, out of request logs
Basecamp stores the launch id and label on the token, and its request lines carry only the id beside the agent (bc3 #13710 filters the label from logged parameters). The comment said the label went into the logs.
1 parent 40a798b commit 16d1351

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎internal/auth/agent_launch.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ import (
2020
// the host, so Basecamp cannot tell one sandboxed box from another: every
2121
// request reads as the agent, from one token. A session mint asks the token
2222
// endpoint for a token of the session's own instead, carrying a random id
23-
// the launcher generated and a label it chose, which Basecamp stores on the
24-
// token and writes beside the agent in its request logs.
23+
// the launcher generated and an optional label it chose. Basecamp stores
24+
// both on the token; its request logs carry the id beside the agent, never
25+
// the label.
2526
//
2627
// The CLI calls this a session; on the wire, and in bc3, it is a launch
2728
// (launch_id, launch_label), because "session" already means the web

0 commit comments

Comments
 (0)