Skip to content

Commit 58b48d0

Browse files
authored
Keep release.sh's DRY_RUN out of the release checks (#844)
make release hands scripts/release.sh DRY_RUN=false, and release.sh ran make release-check with it still exported. test-sync-skills reads a DRY_RUN of its own and accepts only unset, local or remote, so every make release failed its checks before tagging. Run the checks without it.
1 parent 3de107f commit 58b48d0

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎scripts/release.sh‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,10 @@ fi
7878

7979
# --- Run pre-flight checks ---
8080
info "Running release checks"
81-
make release-check
81+
# DRY_RUN is this script's (true/false); the skill-sync tests read a DRY_RUN
82+
# of their own (unset, local or remote) and refuse "false". Keep it out of the
83+
# checks' environment.
84+
env -u DRY_RUN make release-check
8285

8386
# --- Update stable release metadata ---
8487
if [[ "${PRERELEASE}" == "true" ]]; then

0 commit comments

Comments
 (0)