Find an unanswered copy by its title, since it keeps its original's dates

A copy whose start got no answer told the caller to list the
destination's recordings sorted by created_at, newest first, as if the
copy would top the list. Basecamp's Recording::Copier copies created_at
from the original, so the copy sorts where the original would, and on
a busy list or card table the caller looked at the top, saw nothing,
and could copy again.

The hint now lists the destination's recordings in the source's status
without a sort, then says to look for the original's title in the
destination container by name and id. The --profile and --account
scope stays on the listing command, ahead of that sentence.

Author: robzolkos

internal/commands/cards.go

@@ -2071,6 +2071,7 @@ func cardFiling(app *appctx.App, kind basecamp.FilingType, card *basecamp.Card,
 		showCmd:         "basecamp cards show",
 		lookFor:         recordingCopyLookFor("Kanban::Card", cardTableProjectID(table), card.Status),
 		landing:         "The copy lands in that table's Triage, or Done if completed",
+		match:           copyMatch(card.ID, card.Title, table.Title, table.ID),
 		read: func(ctx context.Context, id int64) (filedRecording, error) {
 			filed, err := app.Account().Cards().Get(ctx, id)
 			if err != nil {

internal/commands/cards_filing_test.go

@@ -264,7 +264,7 @@ func TestCardsCopyThatFailsUpstreamIsNotRetryable(t *testing.T) {
 
 	assert.False(t, e.Retryable, "a 502 can follow a copy Basecamp already started")
 	assert.Contains(t, e.Hint, "may have started the copy")
-	assert.Contains(t, e.Hint, "basecamp recordings list Kanban::Card --in 999 --status active --sort created_at --direction desc --all")
+	assert.Contains(t, e.Hint, "basecamp recordings list Kanban::Card --in 999 --status active --all")
 	assert.Len(t, transport.posts, 1)
 }
 
@@ -279,7 +279,7 @@ func TestCardsCopyWithNoReadableAnswerMayHaveStarted(t *testing.T) {
 
 			assert.False(t, e.Retryable, "Basecamp may have started the copy")
 			assert.Contains(t, e.Hint, "may have started the copy")
-			assert.Contains(t, e.Hint, "basecamp recordings list Kanban::Card --in 999 --status active --sort created_at --direction desc --all")
+			assert.Contains(t, e.Hint, "basecamp recordings list Kanban::Card --in 999 --status active --all")
 			assert.Len(t, transport.posts, 1)
 		})
 	}
@@ -440,7 +440,7 @@ func TestCardsCopyStillRunningSaysNotToCopyAgain(t *testing.T) {
 
 	assert.Equal(t, output.CodeInProgress, e.Code)
 	assert.Contains(t, e.Hint, "Do not copy it again")
-	assert.Contains(t, e.Hint, "basecamp recordings list Kanban::Card --in 999 --status active --sort created_at --direction desc --all")
+	assert.Contains(t, e.Hint, "basecamp recordings list Kanban::Card --in 999 --status active --all")
 	assert.Len(t, transport.posts, 1)
 }
 

internal/commands/filing.go

@@ -1,6 +1,7 @@
 package commands
 
 import (
+	"cmp"
 	"context"
 	"errors"
 	"fmt"
@@ -38,9 +39,11 @@ type recordingFiling struct {
 	// showCmd shows a recording of this kind given its id: "basecamp cards show".
 	showCmd string
 	// lookFor lists where a copy lands, so a copy that may have started is
-	// checked for before copying again; landing says where in it, before lookFor.
+	// checked for before copying again; landing says where in it, before
+	// lookFor, and match what tells the copy apart there, after it.
 	lookFor string
 	landing string
+	match   string
 	// read reads back the recording the filing made, by its new id.
 	read func(ctx context.Context, id int64) (filedRecording, error)
 
@@ -152,9 +155,9 @@ func (f recordingFiling) show(id int64) string {
 	return fmt.Sprintf("%s %d%s", f.showCmd, id, f.scope)
 }
 
-// check is the command that lists where a copy lands.
+// check lists where a copy lands and says how to tell the copy apart there.
 func (f recordingFiling) check() string {
-	return f.lookFor + f.scope
+	return f.lookFor + f.scope + ", then " + f.match
 }
 
 func (f recordingFiling) start(ctx context.Context, app *appctx.App) (*basecamp.Filing, error) {
@@ -366,15 +369,26 @@ var filingWait = struct{ first, max, total time.Duration }{
 }
 
 // recordingCopyLookFor lists the recordings of one type in a project in the
-// source's status, newest first and every page. A copy keeps the source's
-// status, so this shows a copy whatever state it was made in. Basecamp's
-// recordings listing serves Todo, Todolist (groups included), Message,
-// Document, Upload, Vault, Kanban::Card and Schedule::Entry.
+// source's status, every page. A copy keeps the source's status, so this shows
+// a copy whatever state it was made in. Basecamp's recordings listing serves
+// Todo, Todolist (groups included), Message, Document, Upload, Vault,
+// Kanban::Card and Schedule::Entry.
 func recordingCopyLookFor(recordableType string, projectID int64, status string) string {
 	if status == "" {
 		status = "active"
 	}
-	return fmt.Sprintf("basecamp recordings list %s --in %d --status %s --sort created_at --direction desc --all", recordableType, projectID, status)
+	return fmt.Sprintf("basecamp recordings list %s --in %d --status %s --all", recordableType, projectID, status)
+}
+
+// copyMatch says what tells a copy of a recording apart in the container it
+// lands in. A copy keeps its original's title, created_at and updated_at, so
+// no sort puts it first; its title in that container finds it.
+func copyMatch(sourceID int64, title, container string, containerID int64) string {
+	name := fmt.Sprintf("the copy of #%d", sourceID)
+	if title != "" {
+		name = fmt.Sprintf("%q", title)
+	}
+	return fmt.Sprintf("look for %s in %s (#%d); a copy has its original's title and dates", name, cmp.Or(container, "the destination"), containerID)
 }
 
 // pollUntil runs check, backing off between runs, until it reports done or

internal/commands/todolists.go

@@ -1123,6 +1123,7 @@ func listFiling(cmd *cobra.Command, app *appctx.App, kind basecamp.FilingType, l
 		showCmd:       "basecamp todolists show",
 		lookFor:       recordingCopyLookFor("Todolist", projectID, list.Status),
 		landing:       "The copy lands in that To-dos",
+		match:         copyMatch(list.ID, list.Name, todoset.Title, todoset.ID),
 		read:          readFiledTodolist(app, list.ID),
 	}, nil
 }
@@ -1157,6 +1158,7 @@ func groupFiling(cmd *cobra.Command, app *appctx.App, kind basecamp.FilingType,
 		showCmd:       "basecamp todolists show",
 		lookFor:       recordingCopyLookFor("Todolist", todolistProjectID(into), group.Status),
 		landing:       "The copy lands in that list",
+		match:         copyMatch(group.ID, group.Name, into.Name, into.ID),
 		read:          readFiledTodolist(app, group.ID),
 	}, nil
 }

internal/commands/todolists_filing_test.go

@@ -177,7 +177,7 @@ func TestTodolistsCopyToAnotherProjectIsNotRetried(t *testing.T) {
 
 	assert.Len(t, transport.posts, 1)
 	assert.False(t, e.Retryable)
-	assert.Contains(t, e.Hint, "basecamp recordings list Todolist --in 999 --status active --sort created_at --direction desc --all")
+	assert.Contains(t, e.Hint, "basecamp recordings list Todolist --in 999 --status active --all")
 }
 
 // A filing's recovery points at `todolists show <id>`, which reads the list by

internal/commands/todos.go

@@ -2651,6 +2651,7 @@ func todoFiling(app *appctx.App, kind basecamp.FilingType, todo *basecamp.Todo,
 		showCmd:         "basecamp todos show",
 		lookFor:         recordingCopyLookFor("Todo", todolistProjectID(list), todo.Status),
 		landing:         "The copy lands in that list",
+		match:           copyMatch(todo.ID, todo.Title, list.Name, list.ID),
 		read: func(ctx context.Context, id int64) (filedRecording, error) {
 			filed, err := app.Account().Todos().Get(ctx, id)
 			if err != nil {

internal/commands/todos_filing_test.go

@@ -493,17 +493,29 @@ func TestTodosCopySeveralToAnotherProjectNeverRetriesAFailedCopy(t *testing.T) {
 	assert.False(t, e.Retryable)
 	assert.Contains(t, e.Message, "Copied 0 of 2 to-dos")
 	assert.Contains(t, e.Hint, "may have started the copy")
-	assert.Contains(t, e.Hint, "basecamp recordings list Todo --in 999 --status active --sort created_at --direction desc --all")
+	assert.Contains(t, e.Hint, "basecamp recordings list Todo --in 999 --status active --all")
+}
+
+// A copy keeps its original's created_at, so no sort brings it to the top of
+// the listing: the hint says to find it by its title in the destination list.
+func TestTodosCopyRecoveryFindsTheCopyByItsTitle(t *testing.T) {
+	transport := &mockTodoFilingTransport{postStatus: 502}
+	run := runTodoFilingCommand(t, transport, NewTodosCmd(), "copy", "456", "--to-project", "Dest", "--to-list", "Later")
+	e := output.AsError(run.err)
+	require.NotNil(t, run.err)
+
+	assert.NotContains(t, e.Hint, "--sort")
+	assert.Contains(t, e.Hint, `basecamp recordings list Todo --in 999 --status active --all, then look for "Task 456" in Later (#902); a copy has its original's title and dates`)
 }
 
 // A copy keeps the source's status, so the listing that looks for it must
-// show that status, newest first and every page.
+// show that status, every page.
 func TestCopyRecoveryListingShowsTheCopyInItsStatus(t *testing.T) {
-	assert.Equal(t, "basecamp recordings list Todo --in 999 --status active --sort created_at --direction desc --all",
+	assert.Equal(t, "basecamp recordings list Todo --in 999 --status active --all",
 		recordingCopyLookFor("Todo", 999, ""))
-	assert.Equal(t, "basecamp recordings list Todolist --in 999 --status archived --sort created_at --direction desc --all",
+	assert.Equal(t, "basecamp recordings list Todolist --in 999 --status archived --all",
 		recordingCopyLookFor("Todolist", 999, "archived"))
-	assert.Equal(t, "basecamp recordings list Kanban::Card --in 999 --status trashed --sort created_at --direction desc --all",
+	assert.Equal(t, "basecamp recordings list Kanban::Card --in 999 --status trashed --all",
 		recordingCopyLookFor("Kanban::Card", 999, "trashed"))
 }
 
@@ -582,7 +594,7 @@ func TestTodosRefuseATodoNamedTwiceBeforeFilingAny(t *testing.T) {
 // would miss the copy and invite a second one.
 func TestFilingFollowUpsNameTheProfileAndAnAccountGivenThisRun(t *testing.T) {
 	const scope = " --profile work --account 99999"
-	todoListing := "basecamp recordings list Todo --in 999 --status active --sort created_at --direction desc --all" + scope
+	todoListing := "basecamp recordings list Todo --in 999 --status active --all" + scope
 	for name, tc := range map[string]struct {
 		transport http.RoundTripper
 		group     func() *cobra.Command
@@ -612,12 +624,12 @@ func TestFilingFollowUpsNameTheProfileAndAnAccountGivenThisRun(t *testing.T) {
 		"a list copy that may have started": {
 			&mockTodoFilingTransport{postStatus: 502}, NewTodolistsCmd,
 			[]string{"copy", "310", "--to-project", "Dest"},
-			"basecamp recordings list Todolist --in 999 --status active --sort created_at --direction desc --all" + scope,
+			"basecamp recordings list Todolist --in 999 --status active --all" + scope,
 		},
 		"a card copy that may have started": {
 			&mockFilingTransport{postStatus: 502}, NewCardsCmd,
 			[]string{"copy", "456", "--to-project", "Dest"},
-			"basecamp recordings list Kanban::Card --in 999 --status active --sort created_at --direction desc --all" + scope,
+			"basecamp recordings list Kanban::Card --in 999 --status active --all" + scope,
 		},
 		"a card move's breadcrumb": {
 			&mockFilingTransport{statuses: []string{"completed"}}, NewCardsCmd,