Skip to content

Commit 91ad689

Browse files
committed
Say what the private gitconfig replaces, and what it does not
Mirrors the seed (basecamp/cli#78 at 1df3bfe5). GIT_CONFIG_GLOBAL stands in for the user's global file only. The system config and any GIT_CONFIG_COUNT settings in the environment still reach every git call the script makes — the race test injects its hooks path through exactly that — so the comment no longer claims the ambient environment is kept out.
1 parent 19d2542 commit 91ad689

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎scripts/sync-skills.sh‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,11 @@ fi
186186
# --- Git configuration for the target ---
187187
#
188188
# A private global config for every git call below: the bot is the identity for
189-
# the commit, and for the one a rejected push makes again, the token goes in as a URL
190-
# rewrite so it never appears in argv or in the remote URL, and nothing from the
191-
# ambient environment (signing, hooks, defaults) reaches the target.
189+
# the commit, and for the one a rejected push makes again, and the token goes in as
190+
# a URL rewrite so it never appears in argv or in the remote URL. Only the user's
191+
# global file is replaced (~/.gitconfig: identity, signing, credential helpers, hooks
192+
# path); the system config and any GIT_CONFIG_COUNT/GIT_CONFIG_KEY_* settings in the
193+
# environment still apply — the test's race case injects a hooks path that way.
192194
export GIT_CONFIG_GLOBAL="${tmpdir}/gitconfig"
193195
cat > "$GIT_CONFIG_GLOBAL" <<GITCFG
194196
[user]

0 commit comments

Comments
 (0)