Skip to content

Commit c56bff3

Browse files
committed
Follow main's rename of the mint hold to a renewal hold
#854 renamed MintHold and its helpers to RenewalHold after this branch was cut, so the session mint and its tests named things that no longer exist.
1 parent 04de105 commit c56bff3

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎internal/auth/agent_launch.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ func (m *Manager) SessionAccessToken(ctx context.Context, id, label string) (str
192192
if err != nil {
193193
if hold != nil {
194194
lockErr := m.store.withKeyLock(ctx, credKey, func() error {
195-
m.rememberMintHold(credKey, hold)
195+
m.rememberRenewalHold(credKey, hold)
196196
return nil
197197
})
198198
if lockErr != nil {

‎internal/auth/agent_launch_test.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ func TestSessionTokenFromAServerThatIgnoresTheSessionFailsClosed(t *testing.T) {
114114
stored, loadErr := m.store.Load(key)
115115
require.NoError(t, loadErr)
116116
assert.Equal(t, "shared-cached", stored.AccessToken)
117-
assert.Nil(t, stored.MintHold, "an unattributing server is no verdict on the credential")
117+
assert.Nil(t, stored.RenewalHold, "an unattributing server is no verdict on the credential")
118118
})
119119
}
120120
}
@@ -137,7 +137,7 @@ func TestSessionTokenRefusedForItsSessionNamesItAndHoldsNothing(t *testing.T) {
137137

138138
stored, loadErr := m.store.Load(key)
139139
require.NoError(t, loadErr)
140-
assert.Nil(t, stored.MintHold)
140+
assert.Nil(t, stored.RenewalHold)
141141
assert.Equal(t, "shared-cached", stored.AccessToken)
142142
}
143143

@@ -159,12 +159,12 @@ func TestSessionTokenRefusalOfTheCredentialIsHeld(t *testing.T) {
159159

160160
stored, loadErr := m.store.Load(key)
161161
require.NoError(t, loadErr)
162-
require.NotNil(t, stored.MintHold)
163-
assert.Equal(t, mintHoldRefused, stored.MintHold.Kind)
162+
require.NotNil(t, stored.RenewalHold)
163+
assert.Equal(t, renewalHoldRefused, stored.RenewalHold.Kind)
164164

165165
_, err = m.SessionAccessToken(context.Background(), testSessionID, "coworker@box")
166166
require.Error(t, err)
167-
assert.ErrorIs(t, err, errMintHeld)
167+
assert.ErrorIs(t, err, errRenewalHeld)
168168
assert.Len(t, as.tokenCalls(), 1, "a held credential was presented again")
169169
}
170170

0 commit comments

Comments
 (0)