Say approvals add or replace by what Basecamp enables for the agent's kind

Basecamp will let team agents add connections too, behind their own
switch (bc3 #13840), so the help, README, rollout doc and connect skill
no longer say shared agents always replace. The CLI can't see the
server's switches, so the copy says what each approval does under either.

Author: jeremy

README.md

@@ -271,8 +271,8 @@ basecamp connect -P my-agent                            # the watcher
 ```
 
 An approval may add a connection or replace an existing one: read the approval
-page before proceeding. Personal agents can have several connections when
-Basecamp enables adding them. Otherwise, and always for shared agents, a new
+page before proceeding. Personal and team agents can have several connections
+where Basecamp enables adding them for that kind of agent. Otherwise a new
 approval replaces the existing connection. This applies to both the CLI and
 Basecamp's HTTP handshake. Do not reconnect just to upgrade the CLI.
 

docs/agent-connections-rollout.md

@@ -3,9 +3,10 @@
 This CLI can merge and release before the server changes. It stores the
 connection secret as opaque data; no connection API, self-disconnect endpoint,
 or server feature switch is required. A second approval **may replace the
-existing connection**: it does on the current server, for shared agents, and
-for personal agents while adding connections is disabled. Only personal agents
-on a server with adding enabled gain another independent connection. Consult
+existing connection**: it does on the current server, and for any agent whose
+kind (personal or team) doesn't have adding connections enabled. Where
+Basecamp has enabled it for the agent's kind, personal first and team later,
+the approval gains another independent connection instead. Consult
 the approval page; do not reconnect merely to upgrade the CLI.
 
 ## Upgrade one host

internal/commands/auth_agent.go

@@ -53,9 +53,9 @@ whenever it needs one, so there is no token to paste and none to renew by
 hand.
 
 An approval may add a connection or replace an existing one; read the
-approval page before proceeding. Personal agents can keep several connections
-when Basecamp has enabled adding them. Otherwise, and always for shared
-agents, connecting replaces the existing connection, wherever it runs.
+approval page before proceeding. An agent, personal or team, keeps several
+connections where Basecamp has enabled adding them for its kind. Otherwise
+connecting replaces the existing connection, wherever it runs.
 
 The device name defaults to this computer's name. Give each profile its own
 --device-name when several on this computer connect the same agent.

internal/commands/connect.go

@@ -61,9 +61,9 @@ off nothing. --hold sets this profile's durable hold: intake and admission run,
 nothing is handed off, and earlier records wait for review, until basecamp
 connect release for this profile. Linux and macOS only.
 
-One connector runs per profile in this state directory. Personal agents can
-run several connections when Basecamp enables adding them; otherwise, and for
-shared agents, a new approval replaces the existing connection. Each profile
+One connector runs per profile in this state directory. An agent can run
+several connections where Basecamp enables adding them for its kind; otherwise
+a new approval replaces the existing connection. Each profile
 serves its own projects and has its own hold. When two connections serve the
 same project, a request both admit can be answered twice.
 

internal/commands/connect_copy_contract_test.go

@@ -23,16 +23,17 @@ func TestTheSkillDocumentsTheDisconnectLineItGets(t *testing.T) {
 	assert.Contains(t, message, "or replaced")
 }
 
-func TestConnectionHelpIsSafeBeforeServerAddsAndForSharedAgents(t *testing.T) {
+func TestConnectionHelpIsSafeBeforeServerAddsForEitherKindOfAgent(t *testing.T) {
 	help := newAuthAgentConnectCmd().Long
 	assert.Contains(t, help, "approval may add a connection or replace")
-	assert.Contains(t, help, "always for shared")
-	assert.Contains(t, help, "when Basecamp has enabled adding")
+	assert.Contains(t, help, "An agent, personal or team, keeps several")
+	assert.Contains(t, help, "where Basecamp has enabled adding them for its kind")
+	assert.NotContains(t, help, "always for shared")
 	assert.NotContains(t, help, "Each approval adds")
 	assert.Contains(t, help, "old connection stays live")
 	assert.Contains(t, help, "not removed or revoked")
 	help = NewConnectCmd().Long
-	assert.Contains(t, help, "otherwise, and for")
-	assert.Contains(t, help, "shared agents")
+	assert.Contains(t, help, "where Basecamp enables adding them for its kind")
+	assert.NotContains(t, help, "shared agents")
 	assert.Contains(t, help, "own hold")
 }

skills/basecamp-connect/SKILL.md

@@ -429,9 +429,9 @@ Ask only what you can't find out.
   create` for an agent: that signs in a person. If Basecamp's instructions
   page connected this agent over HTTP before (a
   `~/.basecamp-agent/credentials.json`; never read it), ask whether the agent
-  is personal or shared. Warn before approval: shared agents and personal
-  agents without adding enabled replace the existing connection; an
-  add-capable personal agent keeps both live. Read the approval page, never
+  is personal or shared. Warn before approval: an agent whose kind (personal
+  or shared) doesn't have adding enabled replaces the existing connection;
+  one whose kind does keeps both live. Read the approval page, never
   assume adding is enabled. Don't delete credential files. If the owner says
   nothing uses the old file, have them disconnect its connection in Basecamp,
   then remove that unused file themselves. Then connect the agent with