connect: refuse an Agent booster at the boost read

The poll lane carries no actor type, so an Agent person the operator
wrongly put in the allowlist passes the gate. The boost read names the
booster's personable type; refuse an Agent there as agent_authored, as
authorTrusted refuses an Agent author.

Author: jeremy

internal/connector/admission/boost.go

@@ -61,7 +61,10 @@ func boostOnRecording(ev Event) (int64, Reason) {
 // The boost must be on the pointer's recording, and its booster must be the
 // performer the gate trusted: the boost is the words handed off, so whoever
 // wrote them is held to the trust the performer was. A read that answered
-// without either is a read that failed.
+// without either is a read that failed. An Agent booster is refused here as
+// agent_authored: the poll lane carries no actor type, so an Agent person the
+// operator wrongly put in the allowlist passes the gate, and this read is
+// where it shows, as an author's type shows in authorTrusted.
 func (a *decision) readBoost(ctx context.Context, ev Event, boostID int64) (*basecamp.Boost, State, Reason, error) {
 	var boost *basecamp.Boost
 	err := a.retry(ctx, func() error {
@@ -82,6 +85,8 @@ func (a *decision) readBoost(ctx context.Context, ev Event, boostID int64) (*bas
 		return nil, StateBlocked, ReasonReadFailed, nil
 	case boost.Booster.ID != ev.Performer():
 		return nil, StateDiscarded, ReasonUntrustedAuthor, nil
+	case boost.Booster.PersonableType == personableAgent:
+		return nil, StateDiscarded, ReasonAgentAuthored, nil
 	}
 	return boost, "", "", nil
 }

internal/connector/admission/boost_test.go

@@ -335,3 +335,19 @@ func TestABoostOnATrashedPostIsStale(t *testing.T) {
 	assert.Equal(t, StateDiscarded, v.State)
 	assert.Equal(t, ReasonStale, v.Reason)
 }
+
+// On the poll lane no actor type shows an agent; an Agent person the operator
+// wrongly allowlisted passes the gate, and the boost read is where it shows.
+func TestAnAllowlistedAgentsBoostIsRefusedByTheBoostRead(t *testing.T) {
+	p := basePolicy()
+	p.Trust = Trust{Mode: TrustAllowlist, OperatorID: operatorID, AllowlistIDs: []int64{allowedID}}
+	f := newFakeReads()
+	boostOn(f, "Comment", agentID, allowedID)
+	f.boosts[boostID].Booster.PersonableType = personableAgent
+
+	v := decide(t, newAdmitter(t, p, f), boostEvent(allowedID))
+	assert.Equal(t, StateDiscarded, v.State)
+	assert.Equal(t, ReasonAgentAuthored, v.Reason)
+	assert.Nil(t, v.Snapshot)
+	assert.Zero(t, f.summaryCalls, "refused before the boosted recording is read")
+}