Repository navigation
Bump basecamp-sdk to v0.28.1 and stamp v0.18.1 - #964
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e3d5e4cd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🟡 Changes recommended
SDK provenance still records v0.28.0, causing the required provenance check and release quality gate to fail.
1 open issue
What changed in this PR
Prepares CLI v0.18.1 with an SDK patch that extends ETag caching to typed operations.
Changes:
- Updates basecamp-sdk from v0.28.0 to v0.28.1 and refreshes dependency checksums.
- Stamps v0.18.1 in the Nix package and both plugin manifests, with an updated Nix vendor hash.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
| nix/package.nix | Updates release version and dependency vendor hash. |
| go.sum | Records SDK v0.28.1 checksums. |
| go.mod | Bumps the SDK dependency to v0.28.1. |
| .codex-plugin/plugin.json | Sets the Codex plugin version to v0.18.1. |
| .claude-plugin/plugin.json | Sets the Claude Code plugin version to v0.18.1. |
Review effort: Balanced
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Two commits, so that v0.18.1 ships only the SDK bump:
make bump-sdk REF=v0.28.1. That updates go.mod, go.sum andinternal/version/sdk-provenance.json.internal/mcpserver/model/PROVENANCE.jsonis regenerated withscripts/sync-mcp-model.shagainst the v0.28.1 tag. The model files themselves are unchanged, since #1030 doesn't touch the API model.If-None-Matchand take bc3's 304 rather than a full re-render, instead of always fetching in full. That's the CPU work on the T2 card for the API hosts.responses/<key>.entryfile per key. An olderetags.jsonand.bodyfiles are ignored, so the first request after upgrading refetches in full.vendorHash, recomputed and verified byscripts/update-nix-flake.sh) and both plugin.json files. The v0.18.1 tag follows once this merges.main has nothing else since v0.18.0, so it's a patch release.