fix: support directory runfiles in Windows launcher - #1274
Open
alex-the-third wants to merge 1 commit into
Open
Conversation
alex-the-third
force-pushed
the
bugfix/windows-directory-runfiles
branch
from
July 24, 2026 17:54
0552a29 to
7a0e5f4
Compare
Collaborator
|
@codex 🙏 |
|
To use Codex here, create an environment for this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support Windows remote execution environments where Bazel provides a runfiles directory without a manifest.
The generated launcher currently forces
RUNFILES_MANIFEST_ONLY=1, and its:rlocationroutine requires a manifest. Simply removing that override is insufficient because the non-manifest path is returned unchanged instead of being resolved beneathRUNFILES_DIR.This change:
RUNFILES_MANIFEST_FILEwhen it identifies a valid manifestRUNFILES_DIR.runfiles/MANIFEST,.runfiles_manifest, and.runfileslocationsRUNFILES_MANIFEST_ONLY=1overrideThis matches Bazel’s native Windows launcher behavior while keeping the change scoped to the manifest-to-directory fallback tracked by the linked issue.
Fixes #1273
Comments
This extracts the gist of #872.
This should be the followup of #1272
as the first commit here is from the other PR.EDIT: the PR was merged, so rebased.