refactor: move tools/private/zipapp to tools/zipapp - #4127
Conversation
The `//tools/private` package is reserved for developer tools used to maintain `rules_python`. The zipapp tools support rule execution and belong under `//tools/` alongside tools like `launcher`. Move `tools/private/zipapp` to `tools/zipapp`, update internal rule attributes, adjust test imports and dependencies, update distribution filegroups, and document the scope of `//tools/private`.
|
TBH I would love to keep each tool next to where it is used. On the other handsome of the tools might be usable from multiple places, so the proposed structure LGTM. |
|
Thought about it a little more and I am thinking that
So Posting here so as to not forget about it myself. :) |
|
I had a similar thought, but slightly different: create a top-level src/ directory for the py code that is closely coupled to the rule implementation. gtg right now, but stepping back: i'm thinking we should think of the code layout in terms of chunks that get used together, or ease of code sharing, or distributable units. e.g. i'd love for prebuilt static binaries to be an option for the tools, and for it to be easy for us to control whether they're prebuilt or built-on-demand-from-source |
The
//tools/privatepackage is reserved for developer tools used tomaintain
rules_python. The zipapp tools support rule execution andbelong under
//tools/alongside tools likelauncher.Move
tools/private/zipapptotools/zipapp, update internal ruleattributes, adjust test imports and dependencies, update distribution
filegroups, and document the scope of
//tools/private.