fix(gazelle): fix module map for old-style namespaces - #4135
Open
gholms wants to merge 1 commit into
Open
Conversation
The performance tweak in bazel-contrib#3415 which parallelized gazelle module map generation calls simplify() on wheels individually, which always results in entries which collapse to the highest level modules which contain __init__.py files. But when two wheels do old-style namespace packages by both including that file under their top-level module, they simplify down to the top-level module, clobber each other when merged, and wind up with one wheel getting mapped for the entire namespace. This causes bug bazel-contrib#3528. We fix this by deferring our call to simplify() until after we've merged all the wheels' module info. Fixes bazel-contrib#3528
aignas
approved these changes
Sep 1, 2026
aignas
left a comment
aignas
left a comment
Collaborator
There was a problem hiding this comment.
I can see that this is just code move and it makes sense, please add news/4135.fixed.md file describing what is fixed. I am happy to backport it to the current dot release.
Collaborator
|
/backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance tweak in #3415 which parallelized gazelle module map generation calls simplify() on wheels individually, which always results in entries which collapse to the highest level modules which contain init.py files. But when two wheels do old-style namespace packages by both including that file under their top-level module, they simplify down to the top-level module, clobber each other when merged, and wind up with one wheel getting mapped for the entire namespace. This causes bug #3528.
We fix this by deferring our call to simplify() until after we've merged all the wheels' module info.
Fixes #3528