Reorder resource prefix strip; fix #1926 - #1927
Open
dougthor42 wants to merge 1 commit into
Open
Conversation
dougthor42
requested review from
WojciechMazur,
mbland and
simuons
as code owners
August 15, 2026 00:00
Author
|
Hmm... interesting. I'll poke around more later. I was hoping this was a super-quick-end-of-friday-workday fix haha. |
PawelLipski
reviewed
Aug 18, 2026
| # Start from absolute resource path and then strip roots so we get to correct short path | ||
| # resource.short_path sometimes give weird results ie '../' prefix | ||
| path = resource.path | ||
| path = _strip_prefix(path, resource.root.path + "/") |
Collaborator
There was a problem hiding this comment.
I'd also add a regression test (expect_bazel_build_failure?), probably just the target layout from #1926 should be enough
Collaborator
|
Whoops looks that it broke many other things, in turn 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reorder resource prefix strip; fix #1926
Motivation
Fix #1926