[mikrotik-dhcp] update lease db on changes

Author: geoffhouse

src/modules/mikrotik-dhcp/TODO.md

@@ -1,5 +1,4 @@
 - add historical entries to CHANGELOG.md
 - add dhcp pool number left to mikrotik dhcp module
 - mikrotik-dhcp should warn when pools are full
-- update db on lease changes
 - add heartbeat status check and worker task

src/modules/mikrotik-dhcp/container/services/lease-add.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const mongoCollection = require("@core/mongo-collection");
 const RouterOSApi = require("@core/routeros-api");
 const configGet = require("@core/config-get");
 const logger = require("@core/logger")(module);
@@ -39,8 +40,27 @@ module.exports = async (params) => {
 
         logger.debug(`Adding lease with params ${JSON.stringify(params)}`);
 
-        await routerOsApi.run("/ip/dhcp-server/lease/add", paramArray);
+        const result = await routerOsApi.run("/ip/dhcp-server/lease/add", paramArray);
         logger.info(`Added lease for address ${params.address}`);
+
+        const newId = result?.[0]?.ret;
+        if (newId) {
+            const dbLeases = await mongoCollection("leases");
+            const dbServers = await mongoCollection("servers");
+            const server = params.server ? await dbServers.findOne({ id: params.server }) : null;
+            await dbLeases.insertOne({
+                id: newId,
+                address: params.address,
+                "mac-address": params["mac-address"],
+                disabled: params.disabled ?? false,
+                dynamic: false,
+                server: server ? server.name : "all",
+                "address-lists": params["address-lists"] || [],
+                comment: params.comment || "",
+                lastUpdated: new Date(),
+            });
+        }
+
         return true;
     } catch (err) {
         err.message = err.stack || err.message;

src/modules/mikrotik-dhcp/container/services/lease-comment.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const mongoCollection = require("@core/mongo-collection");
 const RouterOSApi = require("@core/routeros-api");
 const configGet = require("@core/config-get");
 const logger = require("@core/logger")(module);
@@ -21,7 +22,9 @@ module.exports = async (leaseId, comment) => {
 
         await routerOsApi.run("/ip/dhcp-server/lease/set", [`=numbers=${leaseId}`, `=comment=${comment ? comment : ""}`]);
 
-        //TODO update db
+        const dbLeases = await mongoCollection("leases");
+        await dbLeases.updateOne({ id: leaseId }, { $set: { comment: comment || "", lastUpdated: new Date() } });
+
         return true;
     } catch (err) {
         err.message = err.stack || err.message;

src/modules/mikrotik-dhcp/container/services/lease-disable.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const mongoCollection = require("@core/mongo-collection");
 const RouterOSApi = require("@core/routeros-api");
 const configGet = require("@core/config-get");
 const logger = require("@core/logger")(module);
@@ -21,6 +22,10 @@ module.exports = async (leaseId) => {
 
         await routerOsApi.run("/ip/dhcp-server/lease/disable", ["=numbers=" + leaseId]);
         logger.info(`Disabled lease id ${leaseId}`);
+
+        const dbLeases = await mongoCollection("leases");
+        await dbLeases.updateOne({ id: leaseId }, { $set: { disabled: true, lastUpdated: new Date() } });
+
         return true;
     } catch (err) {
         err.message = err.stack || err.message;

src/modules/mikrotik-dhcp/container/services/lease-enable.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const mongoCollection = require("@core/mongo-collection");
 const RouterOSApi = require("@core/routeros-api");
 const configGet = require("@core/config-get");
 const logger = require("@core/logger")(module);
@@ -21,6 +22,10 @@ module.exports = async (leaseId) => {
 
         await routerOsApi.run("/ip/dhcp-server/lease/enable", ["=numbers=" + leaseId]);
         logger.info(`Enabled lease id ${leaseId}`);
+
+        const dbLeases = await mongoCollection("leases");
+        await dbLeases.updateOne({ id: leaseId }, { $set: { disabled: false, lastUpdated: new Date() } });
+
         return true;
     } catch (err) {
         err.message = err.stack || err.message;

src/modules/mikrotik-dhcp/container/services/lease-makestatic.js

@@ -1,5 +1,6 @@
 "use strict";
 
+const mongoCollection = require("@core/mongo-collection");
 const RouterOSApi = require("@core/routeros-api");
 const configGet = require("@core/config-get");
 const logger = require("@core/logger")(module);
@@ -23,6 +24,9 @@ module.exports = async (leaseId) => {
         await routerOsApi.run("/ip/dhcp-server/lease/make-static", ["=numbers=" + leaseId]);
         logger.info(`Made lease id ${leaseId} static`);
 
+        const dbLeases = await mongoCollection("leases");
+        await dbLeases.updateOne({ id: leaseId }, { $set: { dynamic: false, lastUpdated: new Date() } });
+
         return true;
     } catch (err) {
         err.message = err.stack || err.message;

src/modules/mikrotik-dhcp/container/services/lease-update.js

@@ -73,6 +73,16 @@ module.exports = async (leaseId, formData) => {
             }
         }
 
+        const updateFields = { lastUpdated: new Date() };
+        if (lease.dynamic) updateFields.dynamic = false;
+        if (formData.address) updateFields.address = formData.address;
+        if (formData.comment !== undefined) updateFields.comment = formData.comment || "";
+        if (formData['mac-address']) updateFields['mac-address'] = formData['mac-address'];
+        if (formData.enabled !== undefined) updateFields.disabled = !formData.enabled;
+        if (formData['server']) updateFields.server = formData['server'];
+        if (formData['address-lists'] !== undefined) updateFields['address-lists'] = formData['address-lists'];
+        await dbLeases.updateOne({ id: leaseId }, { $set: updateFields });
+
         return true;
     } catch (err) {
         err.message = err.stack || err.message;