FIX: Remove follow-redirects transitive dependency - #14017
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes dependencies associated with follow-redirects from the root Simorgh package lock and development dependencies, aiming to resolve a Dependabot security alert.
Changes:
- Removed
wait-onandwebpack-dev-serverfrom rootpackage.json. - Removed related transitive dependencies from
yarn.lock. - Removed webpack dev server IP logging that depended on
webpack-dev-server.
Reviewed changes
Copilot reviewed 2 out of 115 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
package.json |
Removes direct dev dependencies and changes AMP validation startup behavior. |
webpack.config.js |
Removes webpack-dev-server import and onListening logging hook. |
yarn.lock |
Prunes removed direct and transitive dependency entries. |
Comments suppressed due to low confidence (2)
package.json:246
- Removing
wait-onbreaks the existingwebpack:dev:serverscript, which still invokeswait-on ./build/public/modern-loadable-stats-local.json. As a resultyarn devwill fail before the Express server watcher starts unless this script is updated or an alternative readiness check is provided.
package.json:249 - Removing
webpack-dev-serverbreaks the existingwebpack:dev:clientscript, which runswebpack serve.webpack-cliexpectswebpack-dev-serverto be installed for that command, soyarn devcan no longer start the client dev server.
emilysaffron
approved these changes
May 14, 2026
shayneahchoon
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of JIRA: https://bbc.atlassian.net/browse/WS-2453
Summary
wait-onandwebpack-dev-serverwhich contained thefollow-redirectstransitive dependency. Both of these dependencies are no longer required by the Next.js appwebpack-dev-serverin the webpack config. This won't do anything as its not used anymore, but just resolves the import error from the removal ofwebpack-dev-serverTesting
Useful Links