Skip to content

FIX: Remove follow-redirects transitive dependency - #14017

Merged
amoore108 merged 5 commits into
latestfrom
FIX-remove-follow-redirects-transitive-dep
May 14, 2026
Merged

FIX: Remove follow-redirects transitive dependency#14017
amoore108 merged 5 commits into
latestfrom
FIX-remove-follow-redirects-transitive-dep

Conversation

@amoore108

@amoore108 amoore108 commented May 14, 2026

Copy link
Copy Markdown
Contributor

Part of JIRA: https://bbc.atlassian.net/browse/WS-2453

Summary

  • Removes wait-on and webpack-dev-server which contained the follow-redirects transitive dependency. Both of these dependencies are no longer required by the Next.js app
  • Removes usage of webpack-dev-server in the webpack config. This won't do anything as its not used anymore, but just resolves the import error from the removal of webpack-dev-server
  • Resolves https://github.com/bbc/simorgh/security/dependabot/238

Testing

  1. List the steps required to test this PR.

Useful Links

@amoore108 amoore108 self-assigned this May 14, 2026
@amoore108
amoore108 marked this pull request as ready for review May 14, 2026 09:52
@amoore108
amoore108 requested a review from a team as a code owner May 14, 2026 09:52
Copilot AI review requested due to automatic review settings May 14, 2026 09:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes dependencies associated with follow-redirects from the root Simorgh package lock and development dependencies, aiming to resolve a Dependabot security alert.

Changes:

  • Removed wait-on and webpack-dev-server from root package.json.
  • Removed related transitive dependencies from yarn.lock.
  • Removed webpack dev server IP logging that depended on webpack-dev-server.

Reviewed changes

Copilot reviewed 2 out of 115 changed files in this pull request and generated 1 comment.

File Description
package.json Removes direct dev dependencies and changes AMP validation startup behavior.
webpack.config.js Removes webpack-dev-server import and onListening logging hook.
yarn.lock Prunes removed direct and transitive dependency entries.
Comments suppressed due to low confidence (2)

package.json:246

  • Removing wait-on breaks the existing webpack:dev:server script, which still invokes wait-on ./build/public/modern-loadable-stats-local.json. As a result yarn dev will fail before the Express server watcher starts unless this script is updated or an alternative readiness check is provided.
    package.json:249
  • Removing webpack-dev-server breaks the existing webpack:dev:client script, which runs webpack serve. webpack-cli expects webpack-dev-server to be installed for that command, so yarn dev can no longer start the client dev server.

Comment thread package.json
@amoore108
amoore108 merged commit 81203d9 into latest May 14, 2026
14 checks passed
@amoore108
amoore108 deleted the FIX-remove-follow-redirects-transitive-dep branch May 14, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants