Remove Express + unused dependencies - #14028
Conversation
… starting the Express app
| "build:storybook": "rm -rf build && cp envConfig/local.env .env && storybook build -c .storybook -o storybook_dist", | ||
| "setupDevEnv": "cp envConfig/local.env .env && rm -rf envConfig/secret.env && ./scripts/checkSecretEnvVariables.sh", | ||
| "dependencyFreshness": "node ./scripts/dependencyFreshness", | ||
| "dev": "yarn setupDevEnv && rm -rf build && run-p webpack:dev:client webpack:dev:server", |
There was a problem hiding this comment.
Instead of outright removing this, could we maybe point dev and other common commands like test to the NextJs folder? Just a lazy suggestion, can prefix commands with something like:
run-p --cwd ./ws-nextjs-app
There was a problem hiding this comment.
Possibly, although I'd encourage we start merging the 2 package.jsons together.
I wouldn't want some weird behaviours happening when folks run the Next app from the root directory, but maybe I'm being overly cautious?
There was a problem hiding this comment.
I'd be in favour of merging the package.jsons, definitely safer. Would be good to audit/review which commands we still want too. I can make a tech ticket for that too
|
|
||
| NB there is further documentation colocated with relevant code. The above list is an index of the top-level documentation of our repo. | ||
|
|
||
| ## Simorgh Overview |
There was a problem hiding this comment.
Feels like this should also be updated rather than removed. May be better done in a tech/other ticket
There was a problem hiding this comment.
I feel like it should be done when/if we uplift the Next.js app to the root directory. Tech ticket is a good idea. Don't really want it kept since it gives a false impression to devs and AI about how the application behaves.
andrewscfc
left a comment
There was a problem hiding this comment.
🚆 Express leaves the station
Summary
URLandfetchwebpackdependency as its used by Storybook@loadableas we now usenext/dynamicfor lazy loading componentsurl-parseas we can now use the nativeURLinterface for constructing URLs@babeldependencies, but not all of them as some are still required to run thesrc/appunit testsgetInitialDatafolders for the page typesapplyBasicPageHandlersand thePageHandlersHigher Order Components as these are not neededsrc/serverfolder which started the Express app. Keeps the utility files still used in the Next.js appsrc/integrationfolder as its no longer used<App />component which rendered the Express apppackage.json--nextJSarg from integration test runner and commandsutilitiesused by the Next.js from the Express app, into the NextutilitiesfolderRenderersfolder into the Next.js app#utilitiesalias to route to thews-nextjs-app/utilitiesfoldertscerrors in the Next appUseful Links