WS-1348-fix(kyrgyz): remove references to discontinued live radio route - #14339
Conversation
There was a problem hiding this comment.
Pull request overview
Removes Kyrgyz live radio route references (now discontinued/redirecting) so that tests and release documentation reflect current product behaviour.
Changes:
- Deleted the Kyrgyz live radio integration test and its Jest snapshot.
- Updated the LiveRadioPage unit test to use Uzbek fixture data for the “no schedule” case instead of Kyrgyz.
- Removed Kyrgyz live radio links from the Simorgh release info documentation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ws-nextjs-app/integration/pages/liveRadio/kyrgyz/canonical.test.ts | Removes the obsolete Kyrgyz live radio canonical integration coverage. |
| ws-nextjs-app/integration/pages/liveRadio/kyrgyz/snapshots/canonical.test.ts.snap | Removes the associated snapshot data for the deleted integration test. |
| src/app/pages/LiveRadioPage/index.test.tsx | Stops importing/using the Kyrgyz live radio fixture; switches to Uzbek for the “no schedule” assertion. |
| docs/Simorgh-Release-Info.mdx | Removes Kyrgyz live radio URLs from release verification links. |
| .eslintrc.js | Adds an import/no-unresolved rule (with an ignore for timezone side-effect imports). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ab81255 to
a8335b1
Compare
| }, | ||
| ]; | ||
| }, | ||
| async redirects() { |
There was a problem hiding this comment.
@vdeksne, to double check, why do we need this redirect? Normally redirections are handled by the Belfrage
There was a problem hiding this comment.
Good point, thank you, I am fixing it now but it was done because:
• It makes local behaviour match the live BBC URL
• It prevents the removed fixture from producing a confusing local 404
• It handles both live_radio and liveradio URL variants
• It avoids restoring discontinued live-radio data
vdeksne
changed the title
Resolves JIRA: WS-1348
Summary
Remove references to Kyrgyz live radio now that the route redirects to the Kyrgyz home page and is no longer broadcasting. This keeps the codebase, docs, and tests aligned with the current product behaviour.
Additional change
This PR also configures ESLint's
import/no-unresolvedrule to ignore imports matching#psammead/moment-timezone-include/tz/.These timezone modules are generated and intentionally excluded from version control. In clean CI checkouts, ESLint cannot resolve them when validating service configuration files, causing lint failures across services. The ignore is scoped only to these generated timezone imports.
Testing
yarn test:lintCode changes
Testing
yarn test:unit -- src/app/pages/LiveRadioPage/index.test.tsxyarn test:unitUseful Links