TRIAGE - DNM: Check workflows - #14350
Open
alex-magana wants to merge 12 commits into
Open
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…into CHORE-add-watch-listen-e2es
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces new Cypress E2E coverage for the /watch and /listen routes (including ATI analytics assertions) and adds/updates local data fixtures to support running those tests reliably in the local environment.
Changes:
- Added new Cypress page-type specs for Watch and Listen, including media-player UI checks and ATI page-view assertions.
- Added new local Optimo JSON fixtures for Tamil and Gujarati assets used by the new Watch test suites.
- Removed an outdated commented-out block from the article page Cypress suite now that Watch/Listen coverage is being reintroduced separately.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ws-nextjs-app/cypress/e2e/pageTypes/watch/tests.ts | Adds Watch media-player UI assertions and duration validation. |
| ws-nextjs-app/cypress/e2e/pageTypes/watch/index.cy.ts | Registers Watch test suites (canonical + ATI analytics) for selected services/environments. |
| ws-nextjs-app/cypress/e2e/pageTypes/listen/tests.ts | Adds Listen media-player assertions (needs correction to target audio blocks). |
| ws-nextjs-app/cypress/e2e/pageTypes/listen/index.cy.ts | Registers Listen test suites (canonical + ATI analytics) for selected environments. |
| ws-nextjs-app/cypress/e2e/pageTypes/articlePage/index.cy.ts | Removes a previously commented-out/disabled Watch/Listen block from the article suite. |
| data/tamil/articles/c36l16ny6klo.json | Adds a local Tamil fixture backing the new Watch suite. |
| data/gujarati/articles/cx2zevlw204o.json | Adds a local Gujarati fixture backing the new Watch suite. |
Suppressed comments (1)
ws-nextjs-app/cypress/e2e/pageTypes/listen/tests.ts:53
- This test fetches a
videoblock and checksmedia.type === 'video', but listen page data contains anaudioblock. As written, the test will skip all assertions when the expected audio block is present (because the condition is false). Switch toaudioand assert the block type before extracting duration metadata.
const media = getBlockData<ArticleContent & { type: string }>(
'video',
pageData,
);
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+44
to
+53
| const media = getBlockData<ArticleContent & { type: string }>( | ||
| 'video', | ||
| pageData, | ||
| ); | ||
|
|
||
| const aresMediaMetaDataBlock = ( | ||
| media?.model.blocks[1] as AresMediaBlock | ||
| ).model.blocks[0] as AresMediaMetadataBlock; | ||
| const { durationISO8601 } = | ||
| aresMediaMetaDataBlock.model.versions[0]; |
Comment on lines
+17
to
+40
| describe( | ||
| 'Video Player', | ||
| { | ||
| retries: 3, | ||
| }, | ||
| () => { | ||
| it('should render a visible media player', () => { | ||
| cy.window() | ||
| .getPageDataFromWindow() | ||
| .then(pageData => { | ||
| const media = getBlockData('video', pageData); | ||
|
|
||
| if (media) { | ||
| cy.get('[data-e2e="media-loader__container"]') | ||
| .first() | ||
| .within(() => { | ||
| cy.get('[data-e2e="media-player"]') | ||
| .should('be.visible') | ||
| .should('have.attr', 'id') | ||
| .and('eq', 'bbcMediaPlayer0'); | ||
| }); | ||
| } | ||
| }); | ||
| }); |
alex-magana
force-pushed
the
CHORE-add-watch-listen-e2es-triage
branch
3 times, most recently
from
August 28, 2026 18:42
7d057ef to
7417f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA:
Summary
A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.
Code changes
Testing
Useful Links